Repository navigation
docs: play the explainer video inline in the README - #230
Merged
Merged
Conversation
GitHub shows an inline video player only for user-attachments URLs. A relative link to an MP4 in the repo renders as a plain link. Upload the video as a user attachment, put its bare URL in the README, and remove the MP4 and poster that were committed in docs/media. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#229 linked a poster image to an MP4 committed in
docs/media/. GitHub renders a relative MP4 link as a plain link, so the README had no inline player.GitHub shows a
<video controls>player only forhttps://github.com/user-attachments/assets/<uuid>URLs. This PR:POST uploads.github.com/user-attachments/assets)docs/media/steplock-explained.mp4and the poster PNG, which nothing else usesVerification
gh api markdownwithcontext=polyhook/steplockrenders the attachment URL as<video src=... controls>.cargo test: 179 passed. All 13 CI checks pass.Kev gate (local Kev)
🤖 Generated with Claude Code