Repository navigation
Conversation
Since #223 (0.2.1) ack.sh can advance several states without the hook firing in between, so the README claim that the agent cannot skip ahead is no longer true. Document the actual guarantee: in-order, one state per ack, every ack audited. Closes #225 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #225
What
README line 52 claimed "Each checklist item requires one full hook invocation to acknowledge. The agent cannot skip ahead." Since #223 (shipped in 0.2.1),
ack.shsets the next state's transitions itself, so it can be run back to back without retrying the gated action — the claim is no longer accurate.This PR takes option 1 from the issue (keep #223's deliberate behavior, fix the docs). The sentence now states the real guarantee:
ack.shcall;ack.shmay run several times in a row, so the hook doesn't guarantee each question was shown first;If you'd rather restore one-question-per-invocation (option 2 — a
shownmarker enforced byack.sh), close this and I'll leave it for a code change. @tupe12334Checks
Docs-only (1 line in
README.md).git diff --checkclean,linecheck .passes (warnings only, pre-existing). No Rust changes, so fmt/clippy/test are unaffected.This pull request was opened by the moadim routine "Open issues → fix PRs (owned repos + my orgs)".
🤖 Generated with Claude Code