Repository navigation
Conversation
Keeps both sides in ConversationViewModel and its test: the listing, role and photos of this branch, and main's photo messages. The stale-download test now builds its ViewModel through the viewModel() helper, which takes an optional listing repository, instead of calling the constructor by hand.
Brings in main's photo messages. The message list keeps its day dividers and now shows photo bubbles in them, with the photos being sent below the newest messages.
peng-0110
previously approved these changes
Nov 19, 2026
peng-0110
left a comment
Contributor
There was a problem hiding this comment.
Found no issues with the changes only a few nitpicks (none block the merge)
- A photo still being sent shows under yesterday's divider. Pending photos sit at the very bottom of the list, below every day divider. If the last message was yesterday and you send a photo today, its bubble sits under "Yesterday" until the upload finishes. A failed photo stays there until it's retried or removed. Putting a "Today" divider above pending photos when the newest day isn't today would fix it.
- "Today" can go stale overnight. now defaults to Instant.now() and is only re-read when the screen recomposes. If the screen sits idle past midnight, yesterday's messages keep the "Today" label until the next update.
- A code comment was wrapped badly by ktfmt in ListingSummary: "...TalkBack says whose listing it / is, / then its details...". Rejoin the lines.
- The PR description is out of date: its Validation says 1419 unit tests, and the count has grown since.
Approving since none of these are blocking.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Closes #305. The conversation screen now matches the rest of its Figma: the other person's avatar and role, a listing summary card, icons on the notices, day dividers, and the empty and error states' icon and tagline.
Stacked on #367 (the ViewModel side). Merge that one first; this PR then retargets
main.What
Userhas no display name.chat/ui/ChatComponents.kt. The inbox doesn't change.Why
#273 built only what its issue and the ViewModel supported. This is the rest of the Figma, now that the ViewModel provides the listing and photos, and listings store a location (#345).
Left out on purpose:
Validation
./gradlew ktfmtCheck check assemble lint: passed (1419 unit tests, 0 failures; no lint issue in the changed files).ConversationScreenTestcases:ConversationDaysTest: midnight in a non-UTC zone, the year format, and dates out of order.connectedCheck(no emulator) and TalkBack on a device.AI use
Claude Code (Claude Opus 5.5) planned the change from the issue and the Figma. It implemented it and wrote the tests, then ran two adversarial reviews and applied their fixes. I reviewed and approved the plan and the split.
🤖 Generated with Claude Code