Skip to content

preserve app-server events on cancellation - #229

Merged
pmbstyle merged 1 commit into
mainfrom
feature/app-server-event-cleanup
Aug 13, 2026
Merged

preserve app-server events on cancellation#229
pmbstyle merged 1 commit into
mainfrom
feature/app-server-event-cleanup

Conversation

@pmbstyle

Copy link
Copy Markdown
Owner

Summary

  • clean up app-server request, notification, and transport waiters on cancellation or timeout
  • preserve request and terminal notification events that become ready at the cancellation boundary
  • add redacted turn-event wait outcome telemetry without changing timeout policy

Root cause

External cancellation could interrupt the event wait before its child tasks were cancelled and awaited. Those leaked queue and event waiters could later consume or obscure protocol events.

Validation

  • uv run pytest tests/test_codex_provider_sessions.py -q
  • uv run pytest -q
  • uv run ruff check .
  • uv run black --check .
  • uv run mypy
  • git diff --check

@coderabbitai

coderabbitai Bot commented Aug 13, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@pmbstyle, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 24 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: ce61dc9c-11c2-4830-8f2c-f7e940db7c0a

📥 Commits

Reviewing files that changed from the base of the PR and between 944aca5 and 2b2d82d.

📒 Files selected for processing (2)
  • src/octopal/infrastructure/providers/codex_provider.py
  • tests/test_codex_provider_sessions.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@pmbstyle
pmbstyle merged commit 71a6c35 into main Aug 13, 2026
7 checks passed
@pmbstyle
pmbstyle deleted the feature/app-server-event-cleanup branch August 13, 2026 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant