Fix possible fix(deps): 17 vulnerable dependencies in go.mod - #387
Closed
begininvoke wants to merge 1 commit into
Closed
Fix possible fix(deps): 17 vulnerable dependencies in go.mod#387begininvoke wants to merge 1 commit into
begininvoke wants to merge 1 commit into
Conversation
Contributor
|
This is missing corresponding updates to go.sum (which should be relevant to any Go repository). This also requires some changes specific to our build system, so this is superseded by #389 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposing a fix for something flagged in
go.mod. It is around line 1.The source‑address restriction in Permissions returned by authentication callbacks was incomplete. Only PublicKeyCallback and VerifiedPublicKeyCallback validated the client's remote address, leaving PasswordCallback, KeyboardInteractiveCallback, NoClientAuthCallback and GSSAPIWithMICConfig.AllowLogin callbacks ignoring the restriction. An attacker could bypass address‑based authentication controls, leading to unauthorized access. This is a critical issue as it effectively nullifies a core security control of the SSH server. Upgrading to golang.org/x/crypto v0.55.0 includes a fix that applies the source‑address check to all authentication callbacks, closing the gap.
Updates vulnerable dependencies to their fixed versions as reported by Trivy.
For reference: rule
CVE-2026-56854. Rated critical.Take or leave whichever parts are useful. If this is not the right approach, closing is fine.
Found with automated scanning (RedGem) and reviewed before opening. If it is not useful, closing it is completely fine.