Repository navigation
chore: migrate test-suite to ESLint config v3 - #2465
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
kpal81xd
force-pushed
the
chore/eslint-config-v3-test-suite
branch
from
October 29, 2026 16:11
ccb47a5 to
6c02d33
Compare
6 tasks done
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of playcanvas/eslint-config#48.
What's Changed
test-suite/package's@playcanvas/eslint-configfrom2.1.0to3.0.0-beta.9and use its/typescriptentry point, matching the root package.@typescript-eslint/parsersetup and the@typescript-eslint/parserandglobalsdevDependencies, which are no longer used.jsdoc/*,no-use-before-define,no-await-in-loopandno-loop-funcoffs,import/no-unresolvedoff for.mjs, theimport/resolversettings, and the globals blocks. That includesconfig/editor, which only appeared in.tsfiles, whereno-undefis off andglobals.d.tstypes them. The only override left is the existing ignore for the vendoredammofixture.import-x/order, top-levelimport type).anys with real types instead of turningno-explicit-anyoff:playcanvastypes (AppBase,Entity,AssetResource<...>), with!/ casts where the tests rely on a component or lookup being present;monaco-editor, the realtime connectionsharedb, observers and event handles@playcanvas/observer, and assets and entities the editor-api types;globals.d.ts: messenger and REST payloads (the REST client returnsunknown), editor-internal objects such as thelayout.assetspanel, and the props tests stamp onwindow.playcanvas2.23.3,monaco-editor0.47.0and@types/sharedb3.3.13as exact-pinned devDependencies, matching the root package, for types only.engines.nodeto^22.13.0 || >=24to match the new config's requirement.test-suite-ci.ymlalready runs Node 26..tsfile compiles to the same JavaScript as onmain, so the edits are type-only.Checks
Manual smoke test
test-suite/lib/pages/assets.tsin an editor with the ESLint extension, from atest-suite/install.Expected: no ESLint problems.
const x: any = 1;.Expected: ESLint flags
@typescript-eslint/no-explicit-anyas an error.assetin a callback such as(asset: Asset) => asset.get('name').Expected: the editor shows the editor-api
Assettype, notany.