Repository navigation
fix: wait for the engine v2 migration to save before reloading - #2438
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
kpal81xd
added
bug
kpal81xd
marked this pull request as ready for review
October 26, 2026 10:21
playcanvas-bot Bot
pushed a commit
that referenced
this pull request
Oct 26, 2026
(cherry picked from commit 64fb9a8)
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's Changed
engineV2and reloads. The reload ran before the server had the change, so it was lost and every load migrated and reloaded again (3–4 reloads before settling). The Editor now waits until the project settings and the current scene have no pending changes, then reloads once.whenNothingPendingto the settings observer.Smoke test:
engineV2unset or false. Expected: the Editor reloads once, then stays open.Checks