Skip to content

Fix search button cascade in light theme - #205

Merged
pitill0 merged 1 commit into
mainfrom
fix/web-centralize-primary-buttons
Jul 27, 2026
Merged

Fix search button cascade in light theme#205
pitill0 merged 1 commit into
mainfrom
fix/web-centralize-primary-buttons

Conversation

@pitill0

@pitill0 pitill0 commented Jul 27, 2026

Copy link
Copy Markdown
Owner

Summary

Fixes the Search submit button styling in the light theme by resolving the actual CSS specificity conflict.

Root cause

The shared light-theme rule in buttons.css:

html[data-theme="light"] button

had greater specificity than the Search-specific rule in search.css:

.search-form button

As a result, the Search button reverted to the generic light-theme appearance and hover behavior.

Changes

  • Moves the Search primary-action colors to buttons.css.
  • Uses a selector with sufficient specificity to win consistently in both themes.
  • Removes duplicated Search color ownership from search.css.
  • Preserves the responsive mobile width rule.
  • Adds regression coverage for the shared Search button styling without confusing visual ownership with responsive layout.

Validation

  • Search button matches the primary-action palette.
  • Hover contrast is correct in light theme.
  • Dark theme behavior remains unchanged.
  • Mobile layout remains unchanged.
  • Full test suite passes: 876 tests.

@pitill0
pitill0 merged commit 044c70b into main Jul 27, 2026
6 checks passed
@pitill0
pitill0 deleted the fix/web-centralize-primary-buttons branch July 29, 2026 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant