Skip to content

fix(web): make composer popups readable and consistently spaced - #31552

Open
flamboh wants to merge 299 commits into
pingdotgg:maria/redesign/2-composer-timelinefrom
flamboh:t3/redesign-fix-composer-popups
Open

flamboh wants to merge 299 commits into
pingdotgg:maria/redesign/2-composer-timelinefrom
flamboh:t3/redesign-fix-composer-popups

Conversation

@flamboh

@flamboh flamboh commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

Fix for the redesign stack, targets layer 2 (#28840).

Note

🤖 GPT-6.1 Sol on behalf of Oliver

In the composer, the approval More button is cramped, an empty @ search shows nothing useful, and Permissions uses its own caption instead of the shared menu label.

Use a text-sized ghost button for approval More, show a neutral hint for an empty @ search, and use MenuGroupLabel for Permissions. Shared menu/autocomplete captions use main's text-muted-foreground token, retaining their faded appearance.

Maria's rewritten layer now owns popup spacing. This PR drops the former CommandGroup/CommandItem spacing variants, extra command-label padding, shared picker font and spacing overrides, and the composer-specific command-label tone API. It keeps her current row sizes, typography, padding, and radii.

Validation:

  • vp run check:changed origin/maria/redesign/2-composer-timeline: formatting, lint, both knip passes, affected-package typechecks, tests in 4 files, and React compiler checks passed.
  • Isolated client, Replay only: empty @ shows the neutral hint. Permissions opens correctly.
  • Web and desktop share these components. Native mobile, provider adapters, RPC contracts, and connection modes are unchanged.

Before / after

What to look for: before, Permissions uses a standalone caption; after, it uses the shared menu label while keeping the faded caption appearance.

Permissions menu before layer 2 and after

Both columns are real client captures in the same light theme at 1280×800. Before is layer 2 at 4fa2945. Dark themes, effort columns, and approval More are not shown in these captures.

Built with GPT-6.1 Sol in the Codex harness through T3 Code.

maria-rcks and others added 30 commits November 5, 2026 03:57
Upstream pingdotgg#29680 removed showAssistantTimestamp from timeline rows, so the
steered-turn test can no longer assert it.
…edesign colors (pingdotgg#29207)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
flamboh and others added 15 commits November 6, 2026 07:11
…it (pingdotgg#29984)

* fix(web): leave the wake-up fold answer unchanged
…ingdotgg#29998)

* fix(web): a running wake-up's streaming answer replaces the previous one below its fold
@maria-rcks
maria-rcks force-pushed the maria/redesign/2-composer-timeline branch from 2dd539b to 4fa2945 Compare November 6, 2026 07:11
…er-popups

Adapt composer popup fixes to Maria's rewritten layer. Keep tray anchoring,
provider rail stability, More sizing, empty-search guidance, semantic permissions
label, and main's muted caption tokens. Drop the superseded spacing systems.
@macroscopeapp
macroscopeapp Bot dismissed their stale review November 6, 2026 08:09

Dismissing prior approval to re-evaluate f470615

macroscopeapp[bot]
macroscopeapp Bot previously approved these changes Nov 6, 2026
@maria-rcks
maria-rcks force-pushed the maria/redesign/2-composer-timeline branch from 4fa2945 to fee33fa Compare November 7, 2026 04:01
@maria-rcks
maria-rcks force-pushed the maria/redesign/2-composer-timeline branch from fee33fa to d5ffcad Compare November 7, 2026 05:53
@macroscopeapp
macroscopeapp Bot dismissed their stale review November 7, 2026 18:56

Dismissing prior approval to re-evaluate 7c5fa20

@github-actions github-actions Bot added size:L 100-499 changed lines (additions + deletions). and removed size:M 30-99 changed lines (additions + deletions). labels Nov 7, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L 100-499 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants