Skip to content

fix(web): restore dark-mode contrast for PR group labels and counts - #31407

Open
Darlingfxx02 wants to merge 2 commits into
pingdotgg:mainfrom
Darlingfxx02:community/pull-request-contrast
Open

Darlingfxx02 wants to merge 2 commits into
pingdotgg:mainfrom
Darlingfxx02:community/pull-request-contrast

Conversation

@Darlingfxx02

Copy link
Copy Markdown

PR group counts are difficult to read in the default dark theme: the small text uses muted-foreground at 50% opacity, giving about 2.64:1 contrast against the black canvas. Group labels at 70% opacity measure about 4.30:1. Open the grouped pull-request list in dark mode to see this in the group headers.

Use the existing opaque muted-foreground token for these headers and counts in dark mode. Both measure about 8.13:1 in the default theme after the change. Light-theme styling is unchanged.

This is submitted under the very small, focused obvious-bug exception: one component's low-contrast text, with no new feature, setting, or workflow change. No prior maintainer approval is claimed.

Verification

  • vp run check:changed 337c5858c33bc7f8f6dfd391a2c279fa0f7e4d17 --concurrency 2 passed: format, lint, both knip checks, typecheck of two affected packages, and the React compiler check.
  • Captured the actual PullRequestGroupHeader JSX before and after with synthetic data and the repository's compiled Tailwind stylesheet. Contrast values use the rendered colors composited over the default background.
  • Light-theme before/after PNGs are byte-identical; light-theme capture.
  • These are isolated component captures, not a full-app walkthrough. Native desktop/mobile and custom themes were not exercised. The shared web component covers web and Electron; the React Native client is unchanged. No tests were added for this purely visual change.
Before After
Dark theme before Dark theme after

Created with GPT-6.1 Sol and GPT-6 Astra in the Codex harness (T3 Code).

@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Nov 5, 2026
@macroscopeapp

macroscopeapp Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at 35ae205

Macroscope's review found this PR approvable — This change improves dark-mode contrast for PR group labels and counts while preserving light-mode styling. Its effects are limited to presentation, with no changes to data or actions.

You can add or adjust custom eligibility rules. Learn more.

@coderabbitai

coderabbitai Bot commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The pull request group header and entry count now use muted-foreground text styling in dark mode. Their existing light-mode styling remains unchanged.

Changes: Pull request group header styling

Layer / File(s) Summary
Add dark-mode text colors
apps/web/src/components/pullRequest/PullRequestListGroups.tsx
The group header and entry count add dark-mode muted-foreground text classes. Existing light-mode styling remains unchanged.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Suggested reviewers: bil0000

Merge Risk: Minimal · up to 2af20

No actionable merge-blocking issue is identified; the change is mergeable after normal checks.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title clearly describes the dark-mode contrast fix for group labels and counts.
Description check Passed The description covers the problem, change, scope exception, verification, screenshots, and agent details. It omits the template headings for Problem, Change, and Scope and approval, and uses a differ…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description covers the problem, change, scope exception, verification, screenshots, and agent details. It omits the template headings for Problem, Change, and Scope and approval, and uses a different heading level for Verification.

Finishing Touches

Generate unit tests (beta)

  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Tip

🎯 Customize your risk assessments

Guide how CodeRabbit assesses merge risk and security architecture risk. Highlight sensitive changes and explain your security boundaries using Merge Risk Instructions and Security Risk Instructions in your review settings. Security architecture risk assessments require the Advanced plan or above.

✅ Automatic approvals, with your rules

Let CodeRabbit approve pull requests once required threads are resolved, pre-merge checks pass, and your risk limits are met. Enable Automatic approvals in review settings, with overrides for teams or file paths.

Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 35ae205 and 2af2055.

Files selected for processing: 1

  • apps/web/src/components/pullRequest/PullRequestListGroups.tsx
Files skipped from review as they are similar to previous changes: 1

  • apps/web/src/components/pullRequest/PullRequestListGroups.tsx

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

…t-contrast

# Conflicts:
#	apps/web/src/components/pullRequest/PullRequestListGroups.tsx
@maria-rcks

Copy link
Copy Markdown
Collaborator

Note

Written by claude-opus-5-5 on behalf of Maria

Merged current main into this branch (merge commit, no rebase). The only conflict was in PullRequestListGroups.tsx: main now passes the header a count prop instead of reading group.entries.length. The resolution keeps {count} and this PR's dark:text-muted-foreground class. Nothing else changed.

Format, lint, knip, and the web typecheck pass on the merge.

Dark mode, /pull-requests with the same data, before:

Dark-mode PR group header before: "Authored 58" label and count dimmed

After:

Dark-mode PR group header after: "Authored 58" label and count at full muted-foreground contrast

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants