Repository navigation
fix(web): restore dark-mode contrast for PR group labels and counts - #31407
Darlingfxx02 wants to merge 2 commits into
Conversation
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This change improves dark-mode contrast for PR group labels and counts while preserving light-mode styling. Its effects are limited to presentation, with no changes to data or actions. You can add or adjust custom eligibility rules. Learn more. |
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
…t-contrast # Conflicts: # apps/web/src/components/pullRequest/PullRequestListGroups.tsx
|
Note Written by Merged current Format, lint, knip, and the web typecheck pass on the merge. Dark mode, After: |


PR group counts are difficult to read in the default dark theme: the small text uses
muted-foregroundat 50% opacity, giving about 2.64:1 contrast against the black canvas. Group labels at 70% opacity measure about 4.30:1. Open the grouped pull-request list in dark mode to see this in the group headers.Use the existing opaque
muted-foregroundtoken for these headers and counts in dark mode. Both measure about 8.13:1 in the default theme after the change. Light-theme styling is unchanged.This is submitted under the very small, focused obvious-bug exception: one component's low-contrast text, with no new feature, setting, or workflow change. No prior maintainer approval is claimed.
Verification
vp run check:changed 337c5858c33bc7f8f6dfd391a2c279fa0f7e4d17 --concurrency 2passed: format, lint, both knip checks, typecheck of two affected packages, and the React compiler check.PullRequestGroupHeaderJSX before and after with synthetic data and the repository's compiled Tailwind stylesheet. Contrast values use the rendered colors composited over the default background.Created with GPT-6.1 Sol and GPT-6 Astra in the Codex harness (T3 Code).