Repository navigation
feat(web): add animations #31271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
+1,132
−268
Closed
feat(web): add animations #31271
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| import type { CSSProperties, ReactNode } from "react"; | ||
|
|
||
| import { useMediaQuery } from "~/hooks/useMediaQuery"; | ||
| import { usePresence } from "~/hooks/usePresence"; | ||
| import { cn } from "~/lib/utils"; | ||
|
|
||
| const EXIT_DURATION_MS = { pop: 140, collapse: 210 } as const; | ||
|
|
||
| /** | ||
| * Keeps conditional content mounted long enough to animate out. The last children shown stay | ||
| * rendered while closing, so callers can pass `null` children once `show` turns false. | ||
| */ | ||
| export function Presence({ | ||
| show, | ||
| children, | ||
| className, | ||
| style, | ||
| variant = "pop", | ||
| }: { | ||
| readonly show: boolean; | ||
| readonly children: ReactNode; | ||
| readonly className?: string; | ||
| readonly style?: CSSProperties; | ||
| readonly variant?: "pop" | "collapse"; | ||
| }) { | ||
| const prefersReducedMotion = useMediaQuery("(prefers-reduced-motion: reduce)"); | ||
| const presence = usePresence( | ||
| show, | ||
| children, | ||
| !prefersReducedMotion, | ||
| null, | ||
| EXIT_DURATION_MS[variant], | ||
| ); | ||
| if (!presence.present) return null; | ||
| return ( | ||
| <div | ||
| data-slot="presence" | ||
| data-closing={show ? undefined : ""} | ||
| inert={!show} | ||
| className={cn(variant === "pop" ? "presence-pop" : "presence-collapse", className)} | ||
| style={style} | ||
| > | ||
| {presence.value} | ||
| </div> | ||
| ); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,74 @@ | ||
| import { useLayoutEffect, useRef } from "react"; | ||
|
|
||
| import { observeResize } from "~/lib/observeResize"; | ||
| import { cn } from "~/lib/utils"; | ||
|
|
||
| /** | ||
| * A highlight that glides to whichever descendant of its parent matches `selector`, so changing | ||
| * selection reads as one thing moving instead of two things blinking. The parent must be | ||
| * positioned. Nothing moves on first paint, and it hides when nothing matches. | ||
| */ | ||
| export function SlidingIndicator({ | ||
| selector, | ||
| className, | ||
| }: { | ||
| readonly selector: string; | ||
| readonly className?: string; | ||
| }) { | ||
| const ref = useRef<HTMLSpanElement>(null); | ||
|
|
||
| // oxlint-disable-next-line t3code/no-unreasoned-state-sync -- follows DOM selection attributes that React state in sibling subtrees owns, writing styles before paint | ||
| useLayoutEffect(() => { | ||
| const indicator = ref.current; | ||
| const parent = indicator?.parentElement; | ||
| if (!indicator || !parent) return; | ||
| let settleFrame = 0; | ||
|
|
||
| const update = () => { | ||
| const target = parent.querySelector<HTMLElement>(selector); | ||
| if (!target) { | ||
| indicator.style.opacity = "0"; | ||
| delete indicator.dataset.ready; | ||
| return; | ||
| } | ||
| const parentRect = parent.getBoundingClientRect(); | ||
| const rect = target.getBoundingClientRect(); | ||
| const x = rect.left - parentRect.left - parent.clientLeft + parent.scrollLeft; | ||
| const y = rect.top - parentRect.top - parent.clientTop + parent.scrollTop; | ||
| indicator.style.width = `${rect.width}px`; | ||
| indicator.style.height = `${rect.height}px`; | ||
| indicator.style.translate = `${x}px ${y}px`; | ||
| indicator.style.opacity = "1"; | ||
| if (indicator.dataset.ready === undefined) { | ||
| cancelAnimationFrame(settleFrame); | ||
| settleFrame = requestAnimationFrame(() => { | ||
| indicator.dataset.ready = ""; | ||
| }); | ||
| } | ||
| }; | ||
|
|
||
| update(); | ||
| const mutations = new MutationObserver(update); | ||
| mutations.observe(parent, { | ||
| subtree: true, | ||
| childList: true, | ||
| attributes: true, | ||
| attributeFilter: ["data-pressed", "aria-current", "aria-selected", "data-active-tab"], | ||
| }); | ||
| const stopObserving = observeResize(parent, update); | ||
| return () => { | ||
| cancelAnimationFrame(settleFrame); | ||
| mutations.disconnect(); | ||
| stopObserving(); | ||
| }; | ||
| }, [selector]); | ||
|
|
||
| return ( | ||
| <span | ||
| ref={ref} | ||
| aria-hidden | ||
| data-slot="sliding-indicator" | ||
| className={cn("sliding-indicator pointer-events-none absolute top-0 left-0", className)} | ||
| /> | ||
| ); | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 Medium
components/SlidingIndicator.tsx:38When
update()runs while an ancestor is scaled, the indicator copiesgetBoundingClientRect()'s rendered dimensions and position into CSS layout coordinates, leaving the highlight undersized and mispositioned after the scale animation ends. Because CSS transforms do not trigger resize observations, this incorrect geometry persists until another observed change; convert the measured geometry into the parent’s untransformed coordinate space before assigning it.🤖 Copy this AI Prompt to have your agent fix this: