Skip to content

fix(web): diff colors follow appearance contrast #28947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
voltcrash wants to merge 3 commits into
base: main
Choose a base branch
from
+16 −16
Open

fix(web): diff colors follow appearance contrast #28947

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
600c201
fix(web): diff colors follow appearance contrast
voltcrash Nov 1, 2026
c03e759
fix(web): preserve light diff word readability
maria-rcks Nov 3, 2026
c40407a
fix(web): keep light diff emphasis within readable opacity
maria-rcks Nov 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 16 additions & 16 deletions apps/web/src/lib/diffRendering.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,37 +291,37 @@ export const DIFF_SURFACE_THEME_UNSAFE_CSS = `
--diffs-bg-buffer-override: color-mix(in srgb, var(--code-background) 90%, var(--code-foreground));

--diffs-bg-addition-override: light-dark(
color-mix(in srgb, var(--code-background) 50%, var(--diff-addition)),
color-mix(in srgb, var(--code-background) 70%, var(--diff-addition))
color-mix(in srgb, var(--code-background) calc(50% - var(--appearance-contrast-boost, 0%) / 4), var(--diff-addition)),
color-mix(in srgb, var(--code-background) calc(70% - var(--appearance-contrast-boost, 0%) / 4), var(--diff-addition))
);
--diffs-bg-addition-number-override: light-dark(
color-mix(in srgb, var(--code-background) 35%, var(--diff-addition)),
color-mix(in srgb, var(--code-background) 60%, var(--diff-addition))
color-mix(in srgb, var(--code-background) calc(35% - var(--appearance-contrast-boost, 0%) / 4), var(--diff-addition)),
color-mix(in srgb, var(--code-background) calc(60% - var(--appearance-contrast-boost, 0%) / 4), var(--diff-addition))
);
--diffs-bg-addition-hover-override: color-mix(in srgb, var(--code-background) 85%, var(--diff-addition));
Comment thread
maria-rcks marked this conversation as resolved.
Resolved
--diffs-bg-addition-emphasis-override: color-mix(
in srgb,
var(--code-background) 80%,
var(--diff-addition)
/* Pierre resolves emphasis on the host, before the diff's overrides can inherit. */
/* Light emphasis stays above t3-light's readable syntax luminance floor. */
--diffs-bg-addition-emphasis: light-dark(
rgb(from var(--diffs-addition-base) r g b / 15%),
Comment thread
maria-rcks marked this conversation as resolved.
Resolved
rgb(from var(--diffs-addition-base) r g b / calc(20% + var(--appearance-contrast-boost, 0%) / 4))
);

--diffs-bg-deletion-override: light-dark(
color-mix(in srgb, var(--code-background) 50%, var(--diff-deletion)),
color-mix(in srgb, var(--code-background) 70%, var(--diff-deletion))
color-mix(in srgb, var(--code-background) calc(50% - var(--appearance-contrast-boost, 0%) / 4), var(--diff-deletion)),
color-mix(in srgb, var(--code-background) calc(70% - var(--appearance-contrast-boost, 0%) / 4), var(--diff-deletion))
);
--diffs-bg-deletion-number-override: light-dark(
color-mix(in srgb, var(--code-background) 35%, var(--diff-deletion)),
color-mix(in srgb, var(--code-background) 60%, var(--diff-deletion))
color-mix(in srgb, var(--code-background) calc(35% - var(--appearance-contrast-boost, 0%) / 4), var(--diff-deletion)),
color-mix(in srgb, var(--code-background) calc(60% - var(--appearance-contrast-boost, 0%) / 4), var(--diff-deletion))
);
--diffs-bg-deletion-hover-override: color-mix(
in srgb,
var(--code-background) 85%,
var(--diff-deletion)
);
--diffs-bg-deletion-emphasis-override: color-mix(
in srgb,
var(--code-background) 80%,
var(--diff-deletion)
--diffs-bg-deletion-emphasis: light-dark(
rgb(from var(--diffs-deletion-base) r g b / 15%),
rgb(from var(--diffs-deletion-base) r g b / calc(20% + var(--appearance-contrast-boost, 0%) / 4))
);

background-color: var(--diffs-bg) !important;
Expand Down
Loading