Use Effect Duration policies in SSH readiness#2894
Draft
cursor[bot] wants to merge 1 commit into
Draft
Conversation
Co-authored-by: Julius Marminge <juliusmarminge@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
Duration.Inputvalues.Durationvalues.Optionwhile preserving millisecond diagnostic fields.Why
This makes the SSH path more idiomatic Effect by keeping timing policies in
effect/Durationand usingOptionfor optional state. Millisecond conversion now happens only at integration/diagnostic boundaries such as remote script placeholders and log fields.UI Changes
None.
Checklist
Note
Replace millisecond number options with
Durationinputs in SSH readiness checkstimeoutMs,intervalMs, andprobeTimeoutMsnumber options withtimeout,interval, andprobeTimeoutacceptingDuration.InputinwaitForHttpReady(tunnel.ts) andrunSshCommand(command.ts).SSH_READY_TIMEOUT_MS) are replaced withDurationconstants; effective timeout values are unchanged.buildRemoteLaunchScriptstill receive millisecond strings, now derived viaDuration.toMillis.runSshCommandandwaitForHttpReadymust update from numeric millisecond options toDuration.Inputoptions.Macroscope summarized 4316922.