Skip to content

perf(ci): workflow-only PRs stop running every package job #28753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
only21mil wants to merge 2 commits into
base: main
Choose a base branch
from
+48 −0
Open

perf(ci): workflow-only PRs stop running every package job #28753

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c9f0c97
perf(ci): workflow-only changes skip package jobs
only21mil Nov 1, 2026
93fa7c4
perf(ci): list the inert workflows by name so new ones still run ever…
only21mil Nov 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions .github/scripts/ci-changes.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,38 @@ const path = require("node:path");

const root = path.resolve(__dirname, "../..");

// Workflows no test reads. ci.yml defines the CI jobs, tests read release.yml
// and web-preview.yml, and a workflow missing from this list runs everything.
const INERT_WORKFLOWS = [
"agent-context-budget",
"deploy-relay",
"desktop-macos-preview",
"desktop-macos-preview-publish",
"issue-labels",
"mobile-android-apk",
"mobile-eas-preview",
"mobile-eas-preview-fork",
"mobile-eas-production",
"mobile-fingerprint-check",
"mobile-fingerprint-label",
"mobile-showcase-screenshots",
"pr-size",
"pr-vouch",
"publish-aur",
"relay-preview",
"relay-preview-cleanup",
"release-desktop",
"stale-needs-more-info",
"thread-transfer-report",
"windows-tests",
];

const INERT = [
/^docs\//,
/^\.(agents|cursor|vscode|devcontainer|macroscope|repos)\//,
/^[^/]+\.md$/,
/^LICENSE$/,
new RegExp(`^\\.github/workflows/(${INERT_WORKFLOWS.join("|")})\\.yml$`),
];

// Shared test setup and vendored mobile dependencies affect every package.
Expand Down
21 changes: 21 additions & 0 deletions scripts/check-changed.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,27 @@ describe("check:changed", () => {
assert.deepStrictEqual(decide(["docs/user/install.md"], packages, false).affected, []);
});

it("runs no package jobs for workflows that package tests do not read", () => {
const packages = readWorkspace();
const { affected, outputs } = decide([".github/workflows/pr-size.yml"], packages, false);
assert.deepStrictEqual(affected, []);
assert.isFalse(Object.values(outputs).some((value) => value === true));
assert.deepStrictEqual(
decide([".github/workflows/pr-size.yml", "apps/web/src/main.tsx"], packages, false).affected,
["@t3tools/scripts", "@t3tools/web"],
);
for (const file of [
".github/workflows/ci.yml",
".github/workflows/release.yml",
".github/workflows/web-preview.yml",
".github/workflows/new-workflow.yml",
".github/scripts/ci-changes.cjs",
".github/actions/ci-changes/action.yml",
]) {
assert.lengthOf(decide([file], packages, false).affected, packages.length, file);
}
});

it.effect(
"keeps weighted steps within the budget, in order, and serial steps one at a time",
() =>
Expand Down
Loading