Skip to content

docs(mobile): put the Android font alias comment beside the font config - #28730

Open
only21mil wants to merge 1 commit into
pingdotgg:mainfrom
only21mil:fix/audit-m127
Open

only21mil wants to merge 1 commit into
pingdotgg:mainfrom
only21mil:fix/audit-m127

Conversation

@only21mil

Copy link
Copy Markdown
Contributor

Problem

In apps/mobile/app.config.ts, the comment explaining why the Android expo-font entries reuse the iOS PostScript names (DMSans-Regular, DMSans-Medium, DMSans-Bold) sits above the whole ExpoConfig, about 90 lines away from those entries. Someone reading or editing the Android font mapping never sees it, and at the top of the config it reads as if it described the entire object.

Change

Move that existing one-line comment, word for word, to sit directly above the android: key inside the expo-font plugin options. The stray blank line it leaves behind goes too. No code or config value changes.

Scope and approval

No issue or discussion. This is a very small, focused fix under CONTRIBUTING's exception: a comment that explains a real constraint is attached to the wrong code. It changes no behavior, and it touches no other comments or files.

Verification

  • The diff is one comment line removed and the same line added, plus one blank line removed.
  • I evaluated the default export of app.config.ts with Node at the base commit and at this branch and compared the JSON. The outputs are byte-identical (same sha256), so the Expo config is unchanged.
  • vp run check:changed 1d626d02d95f9a2343553f6498037ee82290d304 passes: format, lint, knip, typecheck (mobile and scripts), and the one affected test file.

Not checked:

  • No app build or device run. The resolved config is identical, so the native project cannot change.
  • No screenshots. Nothing a user sees changes.

Prior PRs

#3823 by juliusmarminge introduced the font-alias comment. #21514 by maria-rcks shortened it to its current wording. This change only relocates that existing comment.

Generated with Claude Opus 5.5 in T3 Code Nightly

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Nov 1, 2026
@macroscopeapp

macroscopeapp Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at 48f9070

Macroscope's review found this PR approvable — Relocates the Android font-alias explanation beside the relevant font configuration. No executable settings, product defaults, or diagnostic suppressions change.

You can add or adjust custom eligibility rules. Learn more.

@coderabbitai

coderabbitai Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between 1d626d0 and 48f9070.

Files selected for processing: 1
  • apps/mobile/app.config.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

Walkthrough

The Android font-name matching comment moved from above the Expo config declaration to above the Android font definitions. No runtime configuration changed.

Changes: Android font configuration

Layer / File(s) Summary
Relocate Android font comment
apps/mobile/app.config.ts
The comment about matching iOS PostScript names on Android now appears above the Android font definitions in the expo-font plugin. Runtime configuration is unchanged.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Other

Possibly related PRs

  • pingdotgg/t3code#21987: Adds mobile font configuration and iOS and Android font resolution, including the Android expo-font definitions referenced by this comment.

Suggested labels: size:S

Suggested reviewers: maria-rcks

Merge Risk: Minimal · up to 48f90

No actionable merge risk remains from this documentation-only change.

Pre-merge checks: Passed 4
Check name Status Explanation
Title check Passed The title names the change: a docs comment for the Android font alias is moved beside the font config in the mobile app. It matches the raw summary, which says the comment moved above the Android font…
Description check Passed The description follows the template sections (Problem, Change, Scope and approval, Verification). It explains the misplaced comment and the one-line move. It justifies the missing issue or discussion…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the change: a docs comment for the Android font alias is moved beside the font config in the mobile app. It matches the raw summary, which says the comment moved above the Android font definitions in the expo-font plugin with no runtime change. The title's scope is narrow, but it fits the main change and uses a conventional commit format.

Full details: Description check

Explanation

The description follows the template sections (Problem, Change, Scope and approval, Verification). It explains the misplaced comment and the one-line move. It justifies the missing issue or discussion under the small-fix exception with a clear rationale. Verification gives concrete evidence: a byte-identical evaluated config (matching sha256) and a passing check command, and it states what was not checked. The template's title guidance is met. The description omits the optional model/harness attribution line, which is acceptable only if it is not required; it does include a 'Generated with' line, so that item is covered. Overall the description is mostly complete and specific.

Finishing Touches
Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@maria-rcks

maria-rcks commented Nov 2, 2026 •

Copy link
Copy Markdown
Collaborator

Note

Written by gpt-6.1-sol on behalf of Maria

Verified on Android emulator (API 35) against a real dev server

verified head 48f9070fb5b449a1db6ef42b6d5ea43827581672 on the t3 android emulator. installed the matching development client from the shared cache, served this head with metro, and paired it to an isolated dev server on port 13773 using /home/user/t3code/.t3.

created a local project through the app. selected codex gpt-6.1-sol and completed two real turns through the local proxy. the native composer accepted text; the response rendered a heading, bold text, and regular text. returning to the thread list and reopening the conversation preserved both responses. provider protocol logs confirm both turns completed with no error. no mocks or replay provider were used.

this pr only relocates a comment. there is no runtime behavior change or original visual defect to reproduce. evaluating the expo config at the parent and head produced identical JSON, sha256 528cad3c9ea2839de1f8e003fb35e76f5c2e82fa4a32017dd08950f3e28c73df. no code changes were needed. the initial blank app layout cleared after restarting metro with its cache cleared.

the screenshots show before sending and after the first response on the pr head, not a main-versus-head comparison. the recording shows reopening the persisted two-turn conversation.

android native composer before sending

android rendered heading bold and regular response

android reopening the persisted real codex conversation

Not verified

  • ios cannot run on this linux vm.
  • no separate github/main device run or visual comparison.
  • no instrumented proof of font selection before runtime font loading; this was an end-to-end rendering and conversation check.
  • no new local lint, typecheck, or test run. the pr head reports 30 successful checks, zero failing, zero pending.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants