Repository navigation
Conversation
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — Android toasts now scale their icons, spacing, and controls with text size while retaining 48 dp touch targets. The change is presentation-only, with reported Android scaling and Undo verification and no backend or saved-preference changes. You can add or adjust custom eligibility rules. Learn more. |
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
|
Note Written by Verified on Android emulator (API 35) against a real dev serverVerified head At 22 pt, settle and snooze showed readable scaled icons and Undo controls. Undo restored each thread in the client; the server projection also returned to active with no snooze. At 22 pt plus Android 150% font scaling, the action moved onto its own row and remained readable and tappable. The matched large-text comparison below uses the same project and threads. For the baseline, rebuilt Metro with only All 29 existing CI checks were successful when inspected. This pass changed no code, so no new check run was submitted. Not verified
Merge conflict resolutionMerged current Blacksmith Native runtime was not repeated on this merged head: device access is disabled in this VM and no Android device is attached. The earlier Android evidence above covers the unchanged Android implementation. iOS remains unverified. |
# Conflicts: # apps/mobile/src/components/ui/Toast.tsx




Problem
On Android, changing the app's text size scales the settled/snoozed message but leaves much of the toast's icon, spacing, and Undo control fixed. Small text sits inside an oversized container, and larger text makes the surrounding elements look out of proportion.
The toast also has tight padding before the icon and mismatched rounding around Undo, leaving an uneven gap around the button.
Change
Fix Android toast scaling and polish its rounding, spacing, and Undo button while preserving 48 dp touch targets. Icons and controls follow the app and system text scales, with compact padding at larger sizes, coordinated container and button corners, and more space before the icon. Large text can move the action onto a second row.
The change stays in the shared mobile toast component. iOS keeps its existing layout and controls.
Scope and approval
Focused fix for an obvious visual defect in the existing Android font-size setting. It changes toast sizing and visual styling, with no new settings, workflows, or backend behavior. The before/after captures below establish the defect without a separate issue.
Verification
vp run check:changedpassed after rebasing onto currentmain.Full screenshots
Implemented by GPT-6 Astra using the Codex harness. Design reviewed by Claude Opus 5.5 using Claude Agent.