Repository navigation
fix(web): fill combobox search fields - #28512
Draft
JakubMartyniak wants to merge 2 commits into
Draft
JakubMartyniak wants to merge 2 commits into
JakubMartyniak wants to merge 2 commits into
Conversation
github-actions
Bot
added
vouch:unvouched
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reviewer picker search input stops short of the available row, clipping its placeholder and typed text. Make the existing unstyled combobox input fill its wrapper. This also fixes other combobox search fields.
Verified the reviewer picker in light mode with a temporary local permission fixture. The full placeholder and a 24-character search value fit. The test account lacks write access, so the fixture enabled the picker locally without sending a review request. Before and after captures were taken locally; they still need to be uploaded to GitHub.
GitHub CI passed, including web tests, build and typecheck, and lint.
Model: gpt-6.1-terra; harness: Codex.