[1337Crakker]

Problem

Installing a downloaded desktop update always asks "Install update X and restart T3 Code? Any running tasks will be interrupted." This happens even when nothing is running, so the prompt gets clicked through out of habit, which makes it less useful when work really is running.

Change

The prompt is skipped only when every backend the install stops (the local server plus any WSL servers the app runs) is known to be idle:

• its thread list is live, not a cached copy or mid-resync;
• no thread matches isLiveSubagentShell, meaning no live run, pending approval or question, or pending background tasks;
• its terminal list has loaded and no terminal reports hasRunningSubprocess.

Anything unknown keeps today's prompt: the catalog isn't ready, an environment is disconnected or disabled, terminals haven't loaded, or the desktop's backend list (getLocalEnvironmentBootstraps) can't be read or names a backend with no idle environment. Work started from a phone or app.t3.codes on this machine runs on its server, so it counts. SSH-launched servers run under nohup and survive the restart, so they don't count.

Both entry points (the sidebar update button and Settings → About) share useConfirmDesktopUpdateInstall. Its atom is mounted only while an install is offered and re-renders only when the set of idle backends changes. Update everything, remote server updates, and mobile are unchanged.

Scope and approval

This changes product behavior, so I opened #28185 for direction and scope. Maintainer approval is still pending. It overlaps with #26424, which edits the same prompt. Known limits, also listed in #28185:

• Threads archived while waiting on an approval or with background tasks running aren't in the shell; fix(server): reject archiving threads with active turns #23451 covers that on the server.
• Work that starts in the moment between the click and the shutdown can still be interrupted, as it can after Confirm today. Terminal commands are seen through the server's subprocess poll: about once a second in packaged builds, backing off to 60s if process snapshots keep failing.

Verification

• desktopUpdate.logic.test.ts covers the idle rule (waiting thread, terminal command, non-live shell, unloaded terminals) and the backend cross-check (unknown, missing, unreadable, or empty backend lists). vp run check:changed passes.
• I ran the real desktop app (dev:desktop, isolated state) with a temporary renderer shim that reported a downloaded update, which was not committed. Results:
  • Sidebar button, idle: no prompt, and the install was invoked. Dev refuses the install, hence the "Update downloaded" toast.
  • Sidebar button, during a replay turn: prompt shown.
  • Sidebar button, with sleep 600 in a terminal: prompt shown.
  • After the turn ended and the command was stopped: no prompt.
  • Settings → About: no prompt when idle (install invoked), and a prompt while a terminal command ran.
• I couldn't check a real packaged install, WSL backends, or the mobile or app.t3.codes paths against a desktop host.

Before: idle, still asks	After: idle, installs	After: thread running	After: terminal command running

Proved by running the real desktop dev app before and after the change.

Reviewed with sol-loop: 1 round with gpt-6.1-sol. Sol verdict: approved

Created with Claude Opus 5.5 in Claude Code.

🤖 Generated with Claude Code

[macroscopeapp]

Approvability

Verdict: Needs Human Approval

Macroscope's review found this PR requires human approval — Idle desktop updates will install and restart without the previously mandatory confirmation; active or unknown work still triggers the warning. Removing that default confirmation requires a human product decision.

^{You can add or adjust custom eligibility rules. Learn more.}

[coderabbitai]

No actionable comments were generated in the recent review.

Recent review info

Run configuration

• Source mode: Auto
• Repository: pingdotgg/t3code
• Branch: main
• File: .coderabbit.config.ts
• Commit: 15fe283
• Layers: Repository TS config
• Review profile: CHILL
• Plan: Advanced
• Run ID: cb70c07c-fbca-43bc-b528-883a77e7ce57

Commits

Reviewing files that changed from the base of the PR and between 15fe283 and 8b95f4e.

Files selected for processing: 5

• apps/web/src/components/desktopUpdate.logic.test.ts
• apps/web/src/components/desktopUpdate.logic.ts
• apps/web/src/components/settings/SettingsPanels.tsx
• apps/web/src/components/sidebar/SidebarUpdatePill.tsx
• apps/web/src/state/desktopHostedWork.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

Walkthrough

The change adds hosted-environment idleness checks and a shared install-confirmation hook. Settings and sidebar update controls use the hook to skip or show confirmation based on idle and running desktop backend IDs.

Changes: Desktop update confirmation

Layer / File(s)	Summary
Determine hosted-environment idleness apps/web/src/components/desktopUpdate.logic.ts, apps/web/src/state/desktopHostedWork.ts, apps/web/src/components/desktopUpdate.logic.test.ts	The idle check requires a live shell, loaded terminals, no live subagent shell, and no running terminal subprocess. State derives sorted backend IDs only when the catalog and local environments satisfy the required checks. Tests cover idle and non-idle cases.
Decide whether to confirm apps/web/src/components/desktopUpdate.logic.ts, apps/web/src/state/desktopHostedWork.ts	The confirmation logic requires a dialog when backend IDs are unknown, no running backend is reported, or a running backend is not idle. The hook reads running IDs from the desktop bridge and shows the dialog when required.
Use confirmation in update entry points apps/web/src/components/settings/SettingsPanels.tsx, apps/web/src/components/sidebar/SidebarUpdatePill.tsx	The settings and sidebar update controls use the shared confirmation hook before installation. The sidebar enables confirmation only for install actions outside the update-everything flow.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Bug fix

Sequence Diagram(s)

sequenceDiagram
  participant UpdateControl
  participant ConfirmationHook
  participant IdleBackendIds
  participant DesktopBridge
  participant ConfirmationDialog
  UpdateControl->>ConfirmationHook: request install confirmation
  ConfirmationHook->>IdleBackendIds: read idle backend IDs
  ConfirmationHook->>DesktopBridge: read running backend IDs
  ConfirmationHook->>ConfirmationDialog: show dialog when IDs require confirmation

Loading

Suggested reviewers: saphid, t3dotgg, juliusmarminge

Merge Risk: Minimal · up to 8b95f

Updates can restart without a warning when backends appear idle. No merge-blocking issue was established.

Pre-merge checks: 4

Check name	Status	Explanation
Title check		The title names the main change: the desktop update install prompt now warns about interrupted work only when something is running. It matches the raw summary, the objectives, and the description. Its…
Description check		The description follows the template's sections: Problem, Change, Scope and approval, and Verification. The Problem and Change sections are clear and specific. The Scope and approval section links iss…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Title check

Explanation

The title names the main change: the desktop update install prompt now warns about interrupted work only when something is running. It matches the raw summary, the objectives, and the description. Its conventional commit form also matches the template's example. The title is 94 characters, which is longer than the usual short-title guidance, but it stays specific and readable.

Full details: Description check

Explanation

The description follows the template's sections: Problem, Change, Scope and approval, and Verification. The Problem and Change sections are clear and specific. The Scope and approval section links issue #28185, notes that maintainer approval is pending, and lists known limits and overlap with #26424. The Verification section lists focused unit tests, the vp run check:changed result, manual desktop dev-app checks with observed results, and items that were not verified. A before/after image table is included. The template asks for a conventional commit title in the header comment, which the title satisfies. The description does not give the approval comment link that the template asks for, and it relies on pending approval, so a reviewer must confirm that the scope requirement is met before merge. The description also ends with an AI-attribution line that the template asks for. These gaps are not critical, so the check passes.

Finishing Touches

Generate unit tests (beta)

• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

[t3dotgg]

Note

🤖 GPT-6.1 Terra [1m] responding on behalf of Theo

Closing because there is no prior maintainer approval for silently restarting the desktop app when affected backends appear idle. Obtain agreement on that scope in Ideas before requesting reconsideration under the contribution policy.