Skip to content

fix(mobile): capture unfolded Duo store screenshots in portrait - #28012

Open
maria-rcks wants to merge 2 commits into
mainfrom
fix/duo-open-portrait-screenshots
Open

maria-rcks wants to merge 2 commits into
mainfrom
fix/duo-open-portrait-screenshots

Conversation

@maria-rcks

@maria-rcks maria-rcks commented Oct 31, 2026 •

Copy link
Copy Markdown
Collaborator

On an iPhone Duo in an Apple Store, every unfolded (inner display) screenshot on our App Store page rendered sideways. The unfolded set was captured in landscape (2853×2007), while the folded set in the same ten-image iPhone Duo slot is portrait (1398×2034), and the store showed the landscape shots rotated.

The unfolded pose now captures in portrait at 2007×2853, one of the two inner display sizes App Store Connect accepts, so the whole Duo slot is portrait. The Duo no longer goes through the landscape post-rotate step; the iPad keeps its landscape capture.

Before (current store asset, unfolded thread):

Unfolded Duo thread captured in landscape, 2853x2007

Verification: check:changed passes (lint, knip, typecheck, mobile-showcase.test.ts). The portrait Duo capture is unverified. The screenshot workflow cannot create a Duo simulator: its runner has Xcode 26.6, and simctl create fails with Invalid device type: com.apple.CoreSimulator.SimDeviceType.iPhone-Duo (run). Proving it needs pnpm screenshots:mobile --device iphone-duo-closed --device iphone-duo-open on a Mac with the iPhone Duo runtime. Re-uploading the Duo inner set to App Store Connect is a manual step after merge.

Implemented with claude-opus-5-5 through Claude Code.

🤖 Generated with Claude Code

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:S 10-29 changed lines (additions + deletions). labels Oct 31, 2026
@macroscopeapp

macroscopeapp Bot commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at 813c442

Macroscope's review found this PR approvable — Updates unfolded Duo store screenshots to portrait while preserving landscape iPad capture. The change is limited to screenshot tooling and regenerable assets, with store publication remaining manual.

No code changes detected at 9670a75. Prior analysis still applies.

You can add or adjust custom eligibility rules. Learn more.

@coderabbitai

coderabbitai Bot commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The iPhone Duo screenshot configuration now uses portrait orientation for both fold states. The iOS landscape post-rotation path uses a 270-degree rotation. The documentation specifies 2007×2853 as the unfolded upload dimensions.

Changes: iPhone Duo screenshots

Layer / File(s) Summary
Portrait capture and store dimensions
scripts/mobile-showcase.config.ts, scripts/mobile-showcase.ts, docs/operations/mobile-app-store-screenshots.md
Both fold configurations use portrait orientation. The iOS landscape post-rotation path uses a 270-degree rotation. The unfolded upload dimensions are documented as 2007×2853. Closed-fold dimensions remain 1398×2034.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix · Severity of issue fixed: Low

Suggested labels: bugfix

Suggested reviewers: juliusmarminge

Merge Risk: Minimal · up to 9670a

The change is mergeable, but the Duo screenshots still need validation on a supported simulator before upload.

Pre-merge checks: Passed 3 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Description check Warning The problem, change, and verification are clear, but the required scope and approval information and an after screenshot are missing. The template headings are also absent. Add the template headings. Link the triaged issue or maintainer approval, or explain why this is a small, focused fix of an obvious bug. Add an after screenshot when the Duo capture can be verified.
Passed Passed checks: 3 passed

Check name Status Explanation
Title check Passed The title clearly describes the main change: capturing unfolded Duo screenshots in portrait.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Finishing Touches

Generate docstrings

  • Commit to this branch
  • Create a new PR
Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 813c442 and 9670a75.

Files selected for processing: 1

  • scripts/mobile-showcase.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 4 remain after this review.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S 10-29 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant