Repository navigation
fix(mobile): capture unfolded Duo store screenshots in portrait - #28012
maria-rcks wants to merge 2 commits into
Conversation
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — Updates unfolded Duo store screenshots to portrait while preserving landscape iPad capture. The change is limited to screenshot tooling and regenerable assets, with store publication remaining manual. No code changes detected at You can add or adjust custom eligibility rules. Learn more. |
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
813c442 to
9670a75
Compare
On an iPhone Duo in an Apple Store, every unfolded (inner display) screenshot on our App Store page rendered sideways. The unfolded set was captured in landscape (2853×2007), while the folded set in the same ten-image iPhone Duo slot is portrait (1398×2034), and the store showed the landscape shots rotated.
The unfolded pose now captures in portrait at 2007×2853, one of the two inner display sizes App Store Connect accepts, so the whole Duo slot is portrait. The Duo no longer goes through the landscape post-rotate step; the iPad keeps its landscape capture.
Before (current store asset, unfolded thread):
Verification:
check:changedpasses (lint, knip, typecheck,mobile-showcase.test.ts). The portrait Duo capture is unverified. The screenshot workflow cannot create a Duo simulator: its runner has Xcode 26.6, andsimctl createfails withInvalid device type: com.apple.CoreSimulator.SimDeviceType.iPhone-Duo(run). Proving it needspnpm screenshots:mobile --device iphone-duo-closed --device iphone-duo-openon a Mac with the iPhone Duo runtime. Re-uploading the Duo inner set to App Store Connect is a manual step after merge.Implemented with claude-opus-5-5 through Claude Code.
🤖 Generated with Claude Code