Repository navigation
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
t3dotgg
added a commit
that referenced
this pull request
Oct 30, 2026
Based on #27812 by Scott Van Vliet. Co-Authored-By: Scott Van Vliet <782486+svanvliet@users.noreply.github.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
|
Note 🤖 Claude Opus 5.5 responding on behalf of Theo Superseded by #27847, which is merged. It keeps your design: npm lookups on the server, the Changes made on top of this PR:
Thank you for the fix and the clear write-up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Automatic provider-version and T3 release checks contact
registry.npmjs.orgdirectly instead of honoring the server's configured npm registry. In a managed environment this triggers network protection and prevents update discovery, even though npm itself is configured to use the corporate proxy.Related: #24369. Overlaps the provider-lookup fix in #24372; this draft also addresses browser-side T3 release checks.
Change
npm view --global, including native/manual installations and fallback after a failed installer-specific lookup. Preserve installer-authoritative results and existing provider behavior when npm is absent. A configured-npm lookup failure does not retry public npm.Scope and approval
This addresses one underlying problem: release discovery bypassing configured npm registries. No maintainer approval of the broader scope or the compatibility tradeoff below is claimed. Submitting as a draft for feedback; draft status does not waive contribution requirements.
Unresolved behavior needing direction: T3 release-track switching currently requires npm on the primary server's PATH, including standalone/desktop installations. Missing npm now produces an actionable error, but this is still a functional regression from the old browser lookup. This is separate from provider-version resolution, which retains its existing npm-absent behavior.
Possible directions are a narrowly scoped public lookup when npm is genuinely absent, or publishing database-compatibility metadata with first-party release artifacts. This draft does not choose either approach or silently fall back after a configured-registry failure.
Verification
Using the already-installed partial toolchain:
git diff --checkpassed.Before merge, confirm all required checks run and pass in CI. Local full-app verification is blocked by dependency availability and quarantine in the corporate registry—the same environment that exposed this bug, not the same code defect. The locked
electron@44.10.0was confirmed quarantined until November 3, 2026, 10:06:18 AM Pacific.vp run check:changed, complete builds/typechecks, and full-app verification have not passed. Actual WebSocket/multi-connection behavior, mounted UI/network behavior, genuine pnpm behavior, and Windows integration remain unverified. No integrated UI captures are available. Green CI would cover automated checks; integrated app/network verification and the npm-less compatibility decision remain outstanding.Implemented with GPT-6 Astra in T3 Code through the acpRegistry harness. Static review by Claude Opus 5.5.