Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/server/src/provider/ClaudeProvider.ts
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,7 @@ export type ClaudeCapabilitiesProbe = {
readonly apiProvider: string | undefined;
readonly slashCommands: ReadonlyArray<ServerProviderSlashCommand>;
readonly models?: ReadonlyArray<ClaudeModelInfo>;
/** Undefined means get_usage failed; absent windows on success mean no subscription windows, as with API keys. */
/** Omitted when usage collection is skipped or fails; `rate_limits.error` also means failure. Absent windows on success mean no subscription windows. */
readonly usage?: Pick<SDKControlGetUsageResponse, "rate_limits_available" | "rate_limits">;
readonly usageCheckedAt?: string;
};
Expand Down
19 changes: 19 additions & 0 deletions apps/server/src/provider/claudeUsageLimits.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,25 @@ describe("claudeUsageResponseToLimits", () => {
]);
});

it("treats a refused usage read as a failed probe, not as zero windows", () => {
expect(
claudeUsageResponseToLimits({
checkedAt,
response: {
rate_limits_available: true,
rate_limits: {
...({
error: { type: "rate_limit_error", message: "Rate limited. Please try again later." },
} as object),
},
},
}),
).toEqual({
names: noNames,
limits: { checkedAt, windows: [], unavailable: { reason: "probeFailed" } },
});
});

const enterpriseResponse = {
rate_limits_available: true,
rate_limits: {
Expand Down
3 changes: 2 additions & 1 deletion apps/server/src/provider/claudeUsageLimits.ts
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,8 @@ export function claudeUsageResponseToLimits(input: {
readonly checkedAt: string;
}): { readonly limits: ServerProviderUsageLimits; readonly names: ClaudeScopedLimitNames } {
const { response, checkedAt } = input;
if (!response.rate_limits_available || !response.rate_limits) {
// The SDK does not type it, but a refused usage read (e.g. HTTP 429) arrives as `rate_limits: { error }`.
if (!response.rate_limits_available || !response.rate_limits || "error" in response.rate_limits) {
return {
limits: makeUnavailableUsageLimits({
checkedAt,
Expand Down
Loading