Repository navigation
feat(web): switch the composer between rich text and Markdown source from a button or mod+/ #26777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
6fb68f2
feat(web): switch the composer between rich text and Markdown source …
maria-rcks d5b7f4c
fix(web): use the pilcrow icon for the composer Markdown source button
maria-rcks 74e9c2d
fix(web): use a feather for the composer rich text toggle
maria-rcks 4514c4a
feat(web): toggle composer rich text with a configurable shortcut
maria-rcks 0dc58e7
fix(web): leave the rich text setting alone while a question takes a …
maria-rcks 1396b75
fix(web): hydrate client settings before the rich text shortcut flips
maria-rcks a1c2500
fix(web): keep an open citation comment when the rich text shortcut f…
maria-rcks File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| import { FeatherIcon } from "lucide-react"; | ||
|
|
||
| import { updateClientSettings } from "../../hooks/useSettings"; | ||
| import { Button } from "../ui/button"; | ||
| import { Tooltip, TooltipPopup, TooltipTrigger } from "../ui/tooltip"; | ||
|
|
||
| // Same setting as Settings → Chat → Rich text composer. Flipping it remounts the | ||
| // editor; pointer-down is swallowed so a focused editor keeps its caret across that. | ||
| export function ComposerRichTextToggle({ | ||
| richTextEnabled, | ||
| shortcutLabel, | ||
| }: { | ||
| readonly richTextEnabled: boolean; | ||
| readonly shortcutLabel: string | null; | ||
| }) { | ||
| const showingSource = !richTextEnabled; | ||
| return ( | ||
| <Tooltip> | ||
| <TooltipTrigger | ||
| render={ | ||
| <Button | ||
| type="button" | ||
| variant="ghost" | ||
| size="icon-sm" | ||
| aria-label="Markdown source" | ||
| aria-pressed={showingSource} | ||
| data-pressed={showingSource ? "" : undefined} | ||
| onPointerDown={(event) => event.preventDefault()} | ||
| onClick={() => void updateClientSettings({ composerRichTextEnabled: showingSource })} | ||
| /> | ||
| } | ||
| > | ||
| <FeatherIcon /> | ||
| </TooltipTrigger> | ||
| <TooltipPopup> | ||
| {showingSource ? "Show formatting" : "Show Markdown source"} | ||
| {shortcutLabel ? ` · ${shortcutLabel}` : null} | ||
| </TooltipPopup> | ||
| </Tooltip> | ||
| ); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.