Skip to content

fix(mobile): align thread host metadata with the row edge - #25669

Draft
PixPMusic wants to merge 2 commits into
pingdotgg:mainfrom
PixPMusic:fix/mobile-thread-host-inset
Draft

PixPMusic wants to merge 2 commits into
pingdotgg:mainfrom
PixPMusic:fix/mobile-thread-host-inset

Conversation

@PixPMusic

@PixPMusic PixPMusic commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Problem

#25415 added a project-icon-sized inset to the mobile thread metadata. This shifts the machine indicator and host label away from the row's leading edge and wastes horizontal space on narrow screens.

Change

Remove the metadata inset so the machine indicator lines up with the project's leading edge. Keep search excerpts aligned with title text. Icon sizing and alignment from #25668 are now merged into main and included in this PR’s base.

Scope and approval

Alex requested this focused visual correction. It applies to shared iOS/Android Home and sidebar card rows, including the error/PR/provider metadata line. No provider, contract, transport, web/desktop, pending-draft, or slim-row behavior changes.

Verification

  • Rebased onto main 5127de8c29ed, including merged icon scaling fix(mobile): scale and align thread list icons #25668. Current head: 17ccd33141. The remaining diff removes only the metadata inset.
  • vp run check:changed passed formatting, lint, knip, and affected mobile/scripts typechecks after the rebase. All 8 required CI checks passed; CodeRabbit found no actionable issues and Macroscope approved this head.
  • Fresh matched iPhone 18 Pro (iOS 27.0) captures below compare main against this PR at three text scales. Both sides include merged icon scaling. Same sanitized demo fixtures, theme, orientation, and list position; host metadata moves to the leading edge while title/icon sizing remains the same.
  • App text 16 pt with default system size (iOS Large), app text 22 pt with default system size, and app text 16 pt with system XXXL. App text was restored to 16 pt and the original system XXXL preference restored afterward.
  • Android had earlier pre-rebase visual verification; fresh rebased Android captures were not taken because the Pixel failed to boot. Physical devices were not exercised. No cosmetic UI tests added.
iOS text settings Before: main with merged icon scaling After: this PR
16 pt app / default system Before host inset removal: 16 pt app / default system After host inset removal: 16 pt app / default system
22 pt app / default system Before host inset removal: 22 pt app / default system After host inset removal: 22 pt app / default system
16 pt app / XXXL system Before host inset removal: 16 pt app / XXXL system After host inset removal: 16 pt app / XXXL system

Model: GPT-6.1 Sol (medium reasoning) | Harness: Codex in T3 Code

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Oct 26, 2026
macroscopeapp[bot]
macroscopeapp Bot previously approved these changes Oct 26, 2026
@macroscopeapp

macroscopeapp Bot commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at 6ad47c8

Macroscope's review found this PR approvable — Removes an unnecessary inset from mobile thread host metadata so it aligns with the row edge, while leaving title/search alignment unchanged. The change is limited to a small, self-contained visual correction with no broader runtime or data impact.

Notes:

  • No code objects were reviewed. Approvability was decided on eligibility alone.

No code changes detected at eaf2e1c. Prior analysis still applies.

You can add or adjust custom eligibility rules. Learn more.

@coderabbitai

coderabbitai Bot commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Walkthrough

The thread list metadata row no longer applies project-icon-dependent left padding. Its contents use the row’s default layout.

Changes: Thread list alignment

Layer / File(s) Summary
Metadata row alignment
apps/mobile/src/features/threads/thread-list-v2-items.tsx
The metadata row no longer receives titleTextInset as left padding.

Priority: Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Possibly related PRs

Suggested labels: 📱 Native Change

Suggested reviewers: juliusmarminge

Merge Risk: Minimal · up to eaf2e

No actionable merge-blocking issue is identified; normal checks remain appropriate.

Pre-merge checks: Passed 4
Check name Status Explanation
Title check Passed The title clearly and concisely describes the main change: aligning mobile thread host metadata with the row edge.
Description check Passed The description includes all required sections. It explains the problem, change, scope and approval basis, verification steps, observed results, limitations, and UI evidence.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@macroscopeapp
macroscopeapp Bot dismissed their stale review October 27, 2026 01:00

Dismissing prior approval to re-evaluate 6ad47c8

@PixPMusic

Copy link
Copy Markdown
Contributor Author

@maria-rcks btw @juliusmarminge wanted to ponder this layout more so hold off on any auto merges.

Copy link
Copy Markdown
Collaborator

Note

Written by gpt-6.1-sol on behalf of Maria

thanks @PixPMusic. your one-line metadata inset removal already is the smallest fix. i kept your commit and implementation intact and merged main 36dac688a17c into your branch, without rebasing or force-pushing. current head is eaf2e1c764c3d0068043f108f0a6e2a5d380c334; the diff against main remains one line. search excerpts retain their title inset.

verification:

  • passed vp run check:changed through blacksmith: formatting, lint, both knip checks, mobile/scripts typechecks, and five selected react compiler coverage checks.
  • all 31 ci checks passed on this head; no merge conflicts. bot feedback and two independent code reviews found no actionable code issues.
  • current-head native rendering and interactions remain unverified. device access on this vm is disabled and no android device is attached. the default dev server started successfully and was stopped; chrome cannot exercise this native component.
  • i inspected your original matched ios captures below at full size and verified the uploaded images load. these compare your earlier main 5127de8 against 17ccd331, not the newly merged head. fresh ios/android, sidebar, and larger-text captures are still needed.

holding for julius's layout decision as you requested. this pr remains open and has not been merged.

contributor's original before: host metadata inset on main 5127de8

contributor's original after: host metadata at row edge on 17ccd331

GigaZoro pushed a commit to GigaZoro/CodeShip that referenced this pull request Oct 30, 2026
…ingdotgg#25669)

Cherry-picked from pingdotgg#25669

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Copy link
Copy Markdown
Collaborator

Note

Written by gpt-6.1-sol on behalf of Maria

Verified in a real dev environment

No changed behavior could be exercised on this Linux Boat VM. This is an unverifiable result, not a runtime pass.

I read the description, discussion, commit authors, and exact one-line diff at head eaf2e1c764c3d0068043f108f0a6e2a5d380c334. The change removes paddingLeft: titleTextInset from the native thread metadata row in apps/mobile/src/features/threads/thread-list-v2-items.tsx. The search excerpt retains its inset in the source. These are code observations only.

Device preflight returned:

T3 device_list: Agent device access is turned off for this environment.
adb devices -l: List of devices attached [empty]

The repository mobile verification skill requires stopping verification when device access is unavailable. Chrome cannot exercise this React Native component. No source changes, commits, pushes, or new dev servers were made. Existing CI results are not evidence of native behavior.

Not verified

Main reproduction and current-head iOS/Android rendering, Home and sidebar host alignment, error/PR/provider metadata, search excerpt alignment, large text, and row navigation remain unverified. No native client is accessible here, so I did not create stand-in web evidence or claim a Codex turn would verify this layout. No new screenshots or recordings were captured. Main/PR installation and server startup were skipped after the native-device blocker was established.

To complete verification, enable a native device host and compare main and this exact head using app-created project/thread data and real Codex gpt-6.1-sol turns. Capture matching Home/sidebar images and exercise search and thread navigation on that device.

@PixPMusic
PixPMusic marked this pull request as draft October 31, 2026 18:51

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants