Repository navigation
fix(swift-ios): honor the Add project starting directory - #23201
juliusmarminge wants to merge 3 commits into
Conversation
…rectory Carry settings.addProjectBaseDirectory from each environment's server config through FeatureEnvironment so the folder browser, existing-folder path, and clone destination start there, falling back to ~/ when unset or blank. Closes #16507 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…er edits paths A connected environment can publish its shell before its server config, so the Add Project sheet may seed ~/ before addProjectBaseDirectory arrives. Re-seed folder, browse, and clone paths when the setting lands, as long as the user has not browsed, edited a path, or started a clone. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…tory lookup Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ApprovabilityVerdict: Needs Human Approval Macroscope's review found this PR requires human approval — The change threads an existing server setting into the Swift Add Project flow and changes the initial browser, folder, and clone locations for configured environments while retaining the You can add or adjust custom eligibility rules. Learn more. |
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: unavailable · PR result: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
Problem
On the SwiftUI iOS client, Add project always starts its existing-folder browser and clone destination at
~/, even when the selected environment has Add project starts in set to~/projects. The server returns the setting correctly; the native client did not decode or use it.Change
Carry
addProjectBaseDirectoryfrom each environment's server settings into the native environment model. Seed the folder browser, existing-folder path, and clone destination from the trimmed setting, falling back to~/when absent or blank. Environment switches reseed from the selected environment. Late settings update untouched paths, including after repository lookup, while user edits, navigation, and active clone operations retain their paths.Scope and approval
Fixes https://git.cafe/pingdotgg/t3code/issues/16507
Triaged bug via the automated issue flow; GitCafe issue #16507. Swift-only fix against
t3code/rebuild-mobile-app-swift, under the explicit SwiftUI triage guidance. No server, web, desktop, React Native, authentication, permission, or MCP behavior changes. No merge or auto-land requested.Verification
server.getConfigreturns the configured/tmp/issue-16507-projects;filesystem.browseof~/returns/home/ubuntu, and of the configured directory returns/tmp/issue-16507-projects. Runtime transcript. This verifies the host contract, not native rendering.git diff --checkpassed; commit formatter hooks passed. Both requested reviewers (GPT-6.1-Sol and Claude Opus 5.5) returnedMERGEon final head 7a5fcf45e1.bash apps/swift-ios/Scripts/ci-test.shfails withmissing required command: xcodebuildon this Linux VM. No Swift compilation, executable regression tests, or native before/after recordings were produced. Native-check log.Evidence status (native rows require Apple-host verification; no substitute web/RN captures):
Final fixture matrix and proof audit: insufficient native proof, eligible only under the explicit platform exception. The audit pins the first late-config correction; the final commit additionally retries seeding after repository lookup, with the same native proof gap.
Evidence index. Native fixtures and captures remain outstanding for Julius under the Swift platform exception. No visual comparison or claim that nothing else changed is made.
Models: Claude Opus 5.5 and GPT-6.1-Sol, through Claude Agent SDK and Codex in T3 Code.