Skip to content

[Bug]: Edit from here is hidden on Grok and Antigravity and offered on Muse, unlike what the server accepts #30137

Open

Description

@Entrpi

What happens

Whether a client offers Edit from here comes from a hand-set supportsConversationRollback flag in the provider status, while the server decides from the adapter capabilities (ensureRollback in CommandPolicy.ts). The two disagree:

  • Grok (provider-grok/src/server/status.ts) and Antigravity (AntigravityProvider.ts) set the flag to false, so the web hides Edit from here, although the server accepts the rollback.
  • Muse sets no flag, so the web shows Edit from here, and the server refuses it because Muse cannot roll back.

Steps to reproduce (main cefb544af3)

  1. Open a finished Grok or Antigravity thread on web. No sent prompt offers Edit from here.
  2. Open a finished Muse thread. Edit from here is offered, and choosing it fails.

Expected

Edit from here is offered exactly where the server accepts the rollback, from one rule, so a new adapter cannot drift.

I have a fix that derives the status flag from the adapter capabilities with the same predicate the policy enforces, and removes the hand-set flags. It builds on the fix for #30136, which lets ACP rollbacks through the policy. I can open a PR if you want one.

Activity

  1. Entrpi commented on Nov 3, 2026

    @Entrpi
    ContributorAuthor

    The fix is on our fork as one commit on top of the #30136 fix: c8d60f4 (compare).

    ProviderRegistry sets supportsConversationRollback from the adapter capabilities with canRewindConversation, the predicate ensureRollback uses, and the hand-set flags in Cursor, Grok and Antigravity are gone. The new test in ProviderRegistry.test.ts covers an ACP provider (rewinds into a fresh session) and Cursor (cannot rewind); the existing Codex snapshot expectations cover native rewind. Happy to open it as a PR if you want it.

  2. Entrpi commented on Nov 5, 2026

    @Entrpi
    ContributorAuthor

    #30146 closes this issue but covers only the Muse half. On main, Grok (packages/provider-grok/src/server/status.ts:53) and Antigravity (apps/server/src/provider/AntigravityProvider.ts:205) still set supportsConversationRollback: false, so the web hides Edit from here although ensureRollback accepts both. Merging #30146 would close this with that half still open.

    Once #30188 makes ACP rollback keep the conversation, removing those two flags is all that's left. Happy to open that small follow-up after #30188 lands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions