ci: fix CircleCI apt + Slack notification hard-fail - #507
Merged
Conversation
Remove the Cypress image Chrome apt source before apt-get update so jq install is not blocked by an expired Google GPG key. Allow the Cloudflare Pages Slack notification step to fail without failing the workflow when CF_API_TOKEN auth is invalid.
Contributor
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe CircleCI end-to-end test job cleans Chrome APT source files before package installation. The deployment notification workflow continues when the Slack action fails. ChangesCircleCI package setup
Deployment notifications
Estimated code review effort: 2 (Simple) | ~5 minutes ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Install jqbecauseapt-get updatefails on the Cypress image's Chrome apt source (NO_PUBKEY FD533C07C264648F). Remove those sources before updating.buildcheck with Cloudflare API auth error10000. Mark that stepcontinue-on-error: trueso a bad/expiredCF_API_TOKENdoes not block releases (token still needs rotation in repo secrets).Test plan
Summary by CodeRabbit