Encode dots in URL path segments to prevent browser resolution #3746
Open
DL6ER wants to merge 1 commit intodevelopmentfrom
Open
Encode dots in URL path segments to prevent browser resolution #3746DL6ER wants to merge 1 commit intodevelopmentfrom
DL6ER wants to merge 1 commit intodevelopmentfrom
Conversation
…3308) When editing a regex domain that is just "." (single dot), the browser interprets it as a relative path component ("current directory") and resolves it away before sending the request. The server receives an empty string, causing "Invalid request: Specify item in URI". This happens because encodeURIComponent(".") returns "." unchanged — dots are unreserved characters per RFC 3986. The browser only normalizes literal "." and ".." path segments, not percent-encoded "%2E". Add utils.encodePathSegment() which wraps encodeURIComponent and also encodes dots to %2E, then apply it in groups-domains.js (the reported bug) and groups.js (which was also missing encoding entirely). Fixes #3308 Signed-off-by: Dominik <dl6er@dl6er.de>
yubiuser
reviewed
Mar 25, 2026
Member
yubiuser
left a comment
There was a problem hiding this comment.
I tried it and still get a 400 response.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
When editing a regex domain that is just "." (single dot), the browser
interprets it as a relative path component ("current directory") and
resolves it away before sending the request. The server receives an
empty string, causing "Invalid request: Specify item in URI".
This happens because encodeURIComponent(".") returns "." unchanged —
dots are unreserved characters per RFC 3986. The browser only normalizes
literal "." and ".." path segments, not percent-encoded "%2E".
Add utils.encodePathSegment() which wraps encodeURIComponent and also
encodes dots to %2E, then apply it in groups-domains.js (the reported
bug) and groups.js (which was also missing encoding entirely).
Related issue or feature (if applicable): Fixes #3308
Pull request in docs with documentation (if applicable): N/A
By submitting this pull request, I confirm the following:
git rebase)Checklist:
developmentbranch.