Open
Conversation
6 tasks
PromoFaux
reviewed
Apr 21, 2025
Member
|
@ngrigoriev - could you give this branch a go and see if it solves the issues you mentioned in #1085? To test, please clone the repository locally, and run the following from within the directory https://docs.pi-hole.net/docker/build-image/#using-the-built-image |
Member
Author
|
@dschaper any review news? |
Member
|
The only way to trigger this is to set the However, that causes a lot more problems than just being unable to set the caps... |
Member
Author
You can simulate it by setting In your compose file. It will give some errors, but Using the current I'm not saying it is a good idea to start FTL without the caps, but some users might have reasons to do so (see here) |
Member
|
I'm still not really sure how to test this. Rebasing on latest |
PromoFaux
force-pushed
the
caps
branch
2 times, most recently
from
42f9faf to
78ffcbe
Compare
…ested capability Signed-off-by: yubiuser <github@yubiuser.dev>
Signed-off-by: yubiuser <github@yubiuser.dev>
Signed-off-by: yubiuser <github@yubiuser.dev>
Co-authored-by: Adam Warner <me@adamwarner.co.uk> Signed-off-by: yubiuser <github@yubiuser.dev>
rdwebdesign
requested changes
Apr 3, 2026
Comment on lines
+257
to
+258
| echo " Cannot run as non-root." | ||
| echo " If you are seeing this error, please set the environment variable 'DNSMASQ_USER' to the value 'root'" |
Member
There was a problem hiding this comment.
Do we need so many spaces here?
I suggest to use 8 spaces for indentation:
Suggested change
| echo " Cannot run as non-root." | |
| echo " If you are seeing this error, please set the environment variable 'DNSMASQ_USER' to the value 'root'" | |
| echo " Cannot run as non-root." | |
| echo " If you are seeing this error, please set the environment variable 'DNSMASQ_USER' to the value 'root'" |
Comment on lines
+263
to
265
| echo " [!] WARNING: No capabilities for pihole-FTL available." | ||
| echo " Pi-hole functions may not work as expected." | ||
| echo " Please ensure that the container has the required capabilities." |
Member
There was a problem hiding this comment.
Same here.
Use 8 spaces for indentation:
Suggested change
| echo " [!] WARNING: No capabilities for pihole-FTL available." | |
| echo " Pi-hole functions may not work as expected." | |
| echo " Please ensure that the container has the required capabilities." | |
| echo " [!] WARNING: No capabilities for pihole-FTL available." | |
| echo " Pi-hole functions may not work as expected." | |
| echo " Please ensure that the container has the required capabilities." |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improves the capability check. Inspired by #1085 (comment)
It does three things
NET_ADMINeven when this would be the only cap that would be checked and could not be granted.CAP_STRis empty. See the linked comment above. The error was wrong in the first place, as it did not check if we failed to grant the caps but ifCAP_STRis empty. And it is empty if the caps are not available to the container.pihole-FTLfrom checking the user. This should be a two-step process.