check for = false explicitly instead of != true

[mwoolweaver]

What does this PR aim to accomplish?:

check for = false explicitly instead of != true.

---

By submitting this pull request, I confirm the following:

1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
2. I have commented my proposed changes within the code and I have tested my changes.
3. I am willing to help maintain this change if there are issues with it later.
4. It is compatible with the EUPL 1.2 license
5. I have squashed any insignificant commits. (git rebase)
6. I have checked that another pull request for this purpose does not exist.
7. I have considered, and confirmed that this submission will be valuable to others.
8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
9. I give this submission freely, and claim no ownership to its content.

---

• I have read the above and my PR is ready for review. Check this box to confirm

[yubiuser]

I'm not sure about this change. validSession is set by Authenticate() which get it from

https://github.com/mwoolweaver/PADD/blob/16423a6b6ada5e2a436d6b1ffdd79f4dd110a14d/padd.sh#L300C5-L300C17

If anything goes wrong, it might contain something unexpected or is empty. Therefore, I would keep this check as it was

[rdwebdesign]

I agree.

If the curl command (in Authenticate() function) fails with an error message instead of a JSON payload, then jq will also fail.
In this case, validSession will be an empty string and the comparison will return different values.

export validSession=''

if [ "${validSession}" != true ]; then echo "try again"; else echo "stop the loop"; fi

This will print try again.

if [ "${validSession}" = false ]; then echo "try again"; else echo "stop the loop"; fi

This will print stop the loop.

Your command expects the same result in both cases, but we get the opposite when we have a string different than "true" or "false".

We are basically comparing strings here. We want to try again if validSession contains anything different than true, not only when validSession is exactly false.

[yubiuser]

Pinging @mwoolweaver

[yubiuser]

Pinging @mwoolweaver