Skip to content

Make bcround pure#5499

Open
still-dreaming-1 wants to merge 4 commits intophpstan:2.1.xfrom
still-dreaming-1:patch-1
Open

Make bcround pure#5499
still-dreaming-1 wants to merge 4 commits intophpstan:2.1.xfrom
still-dreaming-1:patch-1

Conversation

@still-dreaming-1
Copy link
Copy Markdown

No description provided.

Copy link
Copy Markdown
Contributor

@VincentLanglet VincentLanglet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have to run ./bin/generate-function-metadata.php in order to update also resources/functionMetadata

@still-dreaming-1
Copy link
Copy Markdown
Author

You have to run ./bin/generate-function-metadata.php in order to update also resources/functionMetadata

Ok, thanks. I will try it on my machine. My initial attempt was an edit straight from GitHub.

@VincentLanglet
Copy link
Copy Markdown
Contributor

You have to run ./bin/generate-function-metadata.php in order to update also resources/functionMetadata

Ok, thanks. I will try it on my machine. My initial attempt was an edit straight from GitHub.

Editing manually the second file manually might work too.

@ondrejmirtes
Copy link
Copy Markdown
Member

Never manually edit a generated file 😊

@still-dreaming-1
Copy link
Copy Markdown
Author

still-dreaming-1 commented Apr 20, 2026

Never manually edit a generated file 😊

Good point. I already did, and messed it up, and then hopefully fixed it...

@still-dreaming-1
Copy link
Copy Markdown
Author

I guess if you think it's good enough, you can merge it. Otherwise if you close this without merging I can start over and try it locally on my system. If I do it locally on my system, do I need to install php 8.2? I currently have 8.5.5.

@VincentLanglet
Copy link
Copy Markdown
Contributor

I ran it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants