Repository navigation
Conversation
Native GITHUB_ACTIONS detection ran asynchronously without delaying suite registration. Linux debug CI could therefore run credential-dependent suites before their existing exclusions saw the CI flag, causing keyring errors and cascading login failures. Expose a test-window readiness promise and await it before loading extension suites. Preserve native lookup failures for the runner to report, keep browser detection synchronous, and add eight registered Jasmine cases covering delayed detection, failures, and normal editor windows. No new exclusions or changes to normal editor behavior. Validation: all 8 unit:Test Environment specs passed in the connected Windows Tauri runner; npm run lint and git diff --check passed. Linux GitHub Actions has not been rerun for this change.
Direct agents to the concise Pro task overview and the detailed shared handoff. Require synchronized status and ownership updates, coordination of shared work, and archival of a parent only after all children and required verification are complete. Pin phoenix-pro to 9caab0ec33980aadf66c4b5aa0cd403311f9f90b, which adds the active/completed task files and renames the handoff with updated references. Validation: documentation links and heading anchors resolve; whitespace checks pass. No runtime behavior changed.
Linux Electron suites registered their GitHub Actions exclusions before the asynchronous NodeUtils environment lookup completed. Waiting later in setupAndRunTests did not prevent keyring-dependent core and Pro suites from registering and failing on CI runners without a keyring. Include the CI flag in the existing Node boot response and set it in both native loaders before resolving nodeSetupDonePromise. Wait for that promise before loading SpecRunner's AMD suites, remove the late lookup, and fail startup visibly when boot metadata is missing. Replace helper-only checks with registration-time coverage that compares the inherited environment, boot metadata, and actual credential specs. Validation: environment suite 4/4 on Windows Tauri, macOS Tauri, and Linux Electron with GITHUB_ACTIONS=true; Linux credential and Pro desktop-login exclusion markers each 1/1; full macOS unit category 3039/3039; npm run build and lint passed. Hosted Actions verification remains after push.
Move the Builder listener and local process ownership into the development server. Each stdio MCP adapter connects to the shared hub with its own session, while request routing preserves the existing Phoenix protocol. Include canonical machine IDs in app greetings and status discovery. Add explicit whole-machine reservations with a FIFO queue, dequeue and release operations. Release ownership on adapter socket disconnect without heartbeats, retain source-change notes across disconnects and hub restarts, and return those notes to the next owner. Add read-only polling and a bounded notification callback for reservation monitors. Keep one bounded terminal log history with independent per-agent cursors. Integrate isolated Node fixtures with the existing Jasmine runner and CI test packaging. Document setup, coordination and the remaining host-specific idle wakeup integration. Update the Pro pin to 9ba095f6 for the rollout and verification handoff. Validation: 29/29 Builder specs on Windows Tauri, macOS Tauri and Linux Electron; identity suite 6/6 on Windows; two real stdio adapters verified reply routing and disconnect handoff against a live Linux runner. The development-server startup/shutdown smoke and activated hub reserve/release check passed. Full macOS unit category passed 3039/3039 before the added monitor/log cases. Build passed before heartbeat removal; final targeted lint, syntax checks and commit checks passed. Hosted CI remains to verify.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ask AI transfers currently expose generated context JSON and temporary image paths in the CLI composer. A failed native edit can also leave a reservation behind, causing the next edit to be refused as “another CLI edit is still in progress.” This PR supplies the core changes for a concise question-reference handoff and removes Node-side pending-edit tracking, together with the paired Pro implementation.
Companion: https://github.com/phcode-dev/phoenix-pro/pull/278.
tracking-repos.jsonpins Pro to9379a39aa807f12a17e1476b09f4b5a4a5f03f22.Changes
getUserQuestion(questionId)MCP tool. It retrieves the transferred question, captured source context and screenshot image blocks through the existing authenticated connector. The tool description limits retrieval to IDs supplied in a user transfer.pendingEditsbookkeeping and the disconnected-session exception for completion hooks. Together with Pro's reservation removal, retries no longer depend on an earlier completion hook arriving. Dirty-buffer checked saves and genuine conflict protection remain.Validation
unit:AI CLI Connector50/50 and the companionintegration:AI Connector Peerssuite 33/33.integration:AI CLI Composer17/17 andintegration:AI CLI Connector14/14 passed on Windows, macOS and Linux. These use real terminal fixtures without model access.npm run lint, including the final pre-commit check, and diff checks passed. The handoff revision also passednpm run release:prod; that production build was not repeated after the reservation changes.Existing CLI sessions need restarting to load the new MCP tool catalog. The latest reservation changes have not yet been verified in the running Linux app; that check awaits a reload. Verification details and the separate nonmodal conflict-banner TODO are in the companion Pro documentation.