feat: deferred lettering + visual bible for finished pages - #30
Merged
Conversation
Avoid hard failures on providers that do not support portrait output sizes, and clarify that page plans live in page_cache rather than ChunkCache. Co-authored-by: Cursor <cursoragent@cursor.com>
Lock source-language lettering and overlay real fonts instead of model-painted glyphs; planner boxes with heuristic fallback. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Fit deferred bubbles to text instead of filling huge plan boxes, and force human identity for animal-metaphor nicknames like 虎妞. Co-authored-by: Cursor <cursoragent@cursor.com>
Fit deferred bubbles to text instead of filling huge plan boxes, ask the image model for no chrome at all, and force human identity for animal- metaphor nicknames like 虎妞 so portraits stop becoming tiger heads. Co-authored-by: Cursor <cursoragent@cursor.com>
Bump overlay to deferred_v3: clamp boxes inside page margins, nudge away from faces, sanitize/truncate lettering, and re-letter blanks on resume. Co-authored-by: Cursor <cursoragent@cursor.com>
Strengthen human-identity locks in finished-page prompts and bump render fingerprint to metaphor_v2 so portraits and pages regenerate. Co-authored-by: Cursor <cursoragent@cursor.com>
Lock project-level style/palette and canonical identities (phase B), with hooks reserved for a future visual sheet (phase C). Co-authored-by: Cursor <cursoragent@cursor.com>
Task-sized TDD plan for phase B (schema, reconcile, prompts, pipeline) with C sheet hooks only. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Ensure legacy completed projects bootstrap a bible and soft-invalidate render, rewrite page plans via alias map, resolve assets through bible aliases, stage portrait keys, preserve locked palette/style on update, and pass preferred_style. Co-authored-by: Cursor <cursoragent@cursor.com>
Address wrong merges, prose identities, empty locks, sheet insets, and missing panel character refs (9910 repro). Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Bind loop-scoped state in nested render helpers and clean visual-bible test lint. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
pytest tests/test_lettering_lang.py tests/test_page_lettering.py tests/test_page_prompt.py tests/test_finished_page_pipeline.py tests/test_screenwriter_pages.py tests/test_identity_metaphor.py -qpytest tests/test_visual_bible*.py -qcomic_out/9910f82a3873(or equivalent) and confirm bible_v2 sanitize, no mother↔daughter / count↔novelist merges, no English-prose character assets, period wardrobe / no turnaround insetsMade with Cursor