Repository navigation
Conversation
github-actions Bot
added a commit
to citizenadam/desloppify
that referenced
this pull request
Oct 10, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The unused detector always extended
./tsconfig.app.jsonfrom the current project root. Projects withtsconfig.json, nested packages, or an external scan path could silently lose their actual exclusions and compiler options. A missing-config diagnostic could be ignored while declarations from an unintended scope were reported.Discover the nearest real TypeScript/JavaScript config for scanned files, use the compiler to resolve JSONC and extends, follow project references, and filter rebased diagnostics to scanned files. Find ancestor-installed compilers for nested configs. Configuration errors and interrupted compiler runs now fail explicitly; normal source errors can coexist with valid unused diagnostics. Temporary incremental state stays outside the project's compiler cache.
Validation: 468 TypeScript tests pass, including real-compiler config, exclusion, nested/external path, project-reference, cache, and error regressions. The original excluded-file reproduction now returns no findings. Verified the patched CLI against Alinery (zero unused findings). Independent review reproduced and verified the path/compiler edge cases. Ruff is clean. Full upstream suite: 6,695 passed, 165 skipped, with three unrelated Bash parser failures reproduced on pristine HEAD.
A solution config intentionally validates all referenced projects, even for a narrower source scan; invalid referenced configs remain visible failures.
Fixes #831.