fix: turbostat filename mismatch, missing post-process, and other bugs#55
Open
k-rister wants to merge 1 commit into
Open
fix: turbostat filename mismatch, missing post-process, and other bugs#55k-rister wants to merge 1 commit into
k-rister wants to merge 1 commit into
Conversation
kerneltools-stop: - turbostat-out.txt → turbostat-stdout.txt to match what kerneltools-start actually writes — turbostat data was never archived due to the filename mismatch kerneltools-start: - --interval echo printed turbo_freq instead of interval (copy-paste) - trace-cmd log referenced undefined $trace_cmd_functions — changed to use $trace_cmd_record_opts which is actually set rickshaw.json: - Remove controller.post-script reference to non-existent kerneltools-post-process script boot_to_epoch.py: - .6g → .6f format — .6g switches to scientific notation on systems with long uptime, breaking perf report --time parsing - Fix epoc → epoch, offsect → offset, inidicate → indicate typos - Rename epoc variables to epoch for consistency Closes: #54 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
kerneltools-startwrites toturbostat-stdout.txtbutkerneltools-stoplooks forturbostat-out.txt. Fixed filename in stop script to match.rickshaw.jsonreferencedkerneltools-post-processwhich doesn't exist. Removed the controller block.turbo_freqinstead ofinterval.$trace_cmd_record_opts..6gformat switches to scientific notation on long-uptime systems, breakingperf report --timeparsing. Changed to.6ffor fixed-point.epoc→epoch(5x),offsect→offset,inidicate→indicate.Jira
Test plan
bash -npasses on both shell scriptspython3 -m py_compilepasses on boot_to_epoch.pyjq .validates rickshaw.json🤖 Generated with Claude Code