Repository navigation
Fix response parsing in HTML viewer - #842
Merged
Merged
Conversation
✅ Deploy Preview for padp-staging ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for opi-staging ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for marronage-staging ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for pss-scavenger-hunt ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for relnet-staging ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
blms
reviewed
Nov 12, 2026
Comment on lines
14
to
18
| const text = resp.includes('<tei-text') | ||
| && !resp.toLowerCase().includes('<script') | ||
| && !resp.toLowerCase().includes('<style') | ||
| ? '<tei-text' + resp.split('<tei-text')[1].split('</tei-text>')[0] + '</tei-text>' | ||
| ? '<tei-text' + resp.split(/tei-text[\s>]/)[1].split('</tei-text>')[0] + '</tei-text>' | ||
| : ''; |
Contributor
There was a problem hiding this comment.
This makes sense and I think it's the right approach generally, but it looks like it's outputting malformed structure now. I'm seeing <tei-text><tei-body> get transformed into <tei-text<tei-body>, at least from local testing of this code on dummy tei.
Two small changes could help:
- Using a lookahead like
(?=[\s>])to check the next character aftertei-textwithout removing it, so the>or space aftertei-textstays in the output - Using the same pattern in both the conditional and the split logic, so the conditional ensures the split doesn't result in an error in cases where they don't line up
Something like:
Suggested change
| const text = resp.includes('<tei-text') | |
| && !resp.toLowerCase().includes('<script') | |
| && !resp.toLowerCase().includes('<style') | |
| ? '<tei-text' + resp.split('<tei-text')[1].split('</tei-text>')[0] + '</tei-text>' | |
| ? '<tei-text' + resp.split(/tei-text[\s>]/)[1].split('</tei-text>')[0] + '</tei-text>' | |
| : ''; | |
| const TEI_TEXT_OPENTAG = /<tei-text(?=[\s>])/; | |
| const text = TEI_TEXT_OPENTAG.test(resp) | |
| && !resp.toLowerCase().includes('<script') | |
| && !resp.toLowerCase().includes('<style') | |
| ? '<tei-text' + resp.split(TEI_TEXT_OPENTAG)[1].split('</tei-text>')[0] + '</tei-text>' | |
| : ''; |
Contributor
Author
There was a problem hiding this comment.
Oh damn great catches, thanks! Defeated by regular expressions once again...this is why the machines will replace me. But meanwhile I shall make these fixes!
camdendotlol
approved these changes
Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR
Fixes a bug where responses from fetching the TEI to display in the HTML text viewer were being incorrectly truncated; specifically, we had previously just been looking for the first occurrence of
<tei-textto identify the beginning of the text body, but this fails when the document contains e.g.<tei-textClass>elements, observed in some of the JUEL IATH documents. This PR updates it to look for either<tei-text>or<tei-text, which should be more reliable. Tested and working with existing IATH docs that are broken on the current site.