Repository navigation
Keep Find a route's sections from being squeezed - #82
Merged
Merged
Conversation
The side column scrolls, but its sections could shrink to fit it, and with the Strava and road route sections added the famous climbs list was squeezed to nothing (and long route lists cut short). Sections now keep their height and the column scrolls.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
"Famous climbs" in Find a route showed its heading but no climbs.
The side column has a fixed height and scrolls, but its sections were allowed to shrink to fit it. With the Strava routes and road routes sections added (#77, #78), the climbs list was squeezed to nothing, and long road or mountain-bike route lists were cut short. Sections now keep their height, and the column scrolls.
Checked
npm run checkpasses.