Repository navigation
Ride bends on a smooth curve, and lean into them - #81
Merged
Merged
Conversation
The rider's heading was taken over a fixed window round the sample behind them, so it held still between samples and jumped at each one: through a corner the rider turned in steps. It's now blended between neighbouring samples, centred where the rider is, in both the page's renderer and the native one.
The line between route samples was straight, so a tight bend was a kink every 5 m, and the heading was averaged over 25 m, longer than a hairpin. Riders now follow a Catmull-Rom curve through the samples and face along it. Riders also lean into bends by what balances the turn at their speed, atan(v² / g r), up to 40°, on top of any banking. Both renderers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Riders didn't flow through bends: they moved in a series of small snaps, and they stayed upright however tight the turn.
Checked
npm run checkpasses.