Skip to content

Forgot to register cpp11 functions #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pepijn-devries merged 1 commit into from
Nov 10, 2025
Merged

Forgot to register cpp11 functions #44

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DESCRIPTION
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Package: ProTrackR2
Title: Manipulate and Play 'ProTracker' Modules
Version: 0.0.6.0013
Version: 0.0.6.0014
Authors@R: c(
person("Pepijn", "de Vries", role = c("aut", "cre"),
email = "pepijn.devries@outlook.com",
Expand Down
6 changes: 4 additions & 2 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
ProTrackR2 v0.0.6.0013
ProTrackR2 v0.0.6.0014
-------------

* Implemented `as_pt2cell()` and `as_pt2celllist()`
Expand All @@ -10,9 +10,11 @@ ProTrackR2 v0.0.6.0013
* `pt2_loop_start()` and `pt2_loop_length()`
* `pt2_is_looped()`
* `pt_sample_to_audio()`
* Fixes in (amongst others):
* Selection and assignment operators
* Sample read and write functions
* Added testthat workflow
* Added codecov workflow
* Fixes in (amongst others) selection and assignment operators

ProTrackR2 v0.0.5
-------------
Expand Down
4 changes: 0 additions & 4 deletions R/cpp11.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,10 +104,6 @@ mod_sample_info_ <- function(mod, idx) {
.Call(`_ProTrackR2_mod_sample_info_`, mod, idx)
}

mod_sample_as_int_ <- function(mod, idx) {
.Call(`_ProTrackR2_mod_sample_as_int_`, mod, idx)
}

validate_sample_raw_ <- function(smp_data) {
.Call(`_ProTrackR2_validate_sample_raw_`, smp_data)
}
Expand Down
8 changes: 0 additions & 8 deletions src/cpp11.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,13 +188,6 @@ extern "C" SEXP _ProTrackR2_mod_sample_info_(SEXP mod, SEXP idx) {
END_CPP11
}
// samples.cpp
integers mod_sample_as_int_(SEXP mod, int idx);
extern "C" SEXP _ProTrackR2_mod_sample_as_int_(SEXP mod, SEXP idx) {
BEGIN_CPP11
return cpp11::as_sexp(mod_sample_as_int_(cpp11::as_cpp<cpp11::decay_t<SEXP>>(mod), cpp11::as_cpp<cpp11::decay_t<int>>(idx)));
END_CPP11
}
// samples.cpp
logicals validate_sample_raw_(raws smp_data);
extern "C" SEXP _ProTrackR2_validate_sample_raw_(SEXP smp_data) {
BEGIN_CPP11
Expand All @@ -217,7 +210,6 @@ static const R_CallMethodDef CallEntries[] = {
{"_ProTrackR2_mod_length_", (DL_FUNC) &_ProTrackR2_mod_length_, 1},
{"_ProTrackR2_mod_name_", (DL_FUNC) &_ProTrackR2_mod_name_, 1},
{"_ProTrackR2_mod_pattab_", (DL_FUNC) &_ProTrackR2_mod_pattab_, 1},
{"_ProTrackR2_mod_sample_as_int_", (DL_FUNC) &_ProTrackR2_mod_sample_as_int_, 2},
{"_ProTrackR2_mod_sample_as_raw_", (DL_FUNC) &_ProTrackR2_mod_sample_as_raw_, 2},
{"_ProTrackR2_mod_sample_info_", (DL_FUNC) &_ProTrackR2_mod_sample_info_, 2},
{"_ProTrackR2_mod_set_sample_", (DL_FUNC) &_ProTrackR2_mod_set_sample_, 3},
Expand Down
Loading