Repository navigation
test(sidebar): expect the child label to take the chevron column - #746
Merged
Merged
Conversation
The native sidebar probe still subtracted the fold chevron's column from the child row's label width. Since #715 a row without a drawn chevron no longer reserves that column, so the label is 18px wider and the Windows native GUI jobs failed with "child label width: actual 179px, expected 161px" on main and every branch. The probe and its unit tests now expect the full width.
 [Low impact] This test-only change appears safe to merge. SummaryUpdates the native sidebar probe to match child labels that use the empty chevron column.
Reviews (1) · Last reviewed commit: "test(sidebar): expect the child label to..." · Reviewed by Greptile |
Owner
Author
|
|
9 of 14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mainhas been red since #715: both Windows native GUI jobs failnative_sidebarwith#715 (
cc727de8) stopped reserving the 18px fold-chevron column on rows that draw no chevron, so a child row's label is now 18px wider. The native probe'sverify_childstill subtractedARROW_RESERVE. It now expects the full width, and the probe unit tests (probes.rs,probe_bar.rs,probe_scale.rs) move every width up by the same 18px.No production code changes.
Validation
cargo test --locked -p herdr-gpui --bin herdr-gpui -- sidebar: 338 passed, 0 failed (macOS arm64)just format: cleanQA checklist
Windows native GUI (windows-2025)and(windows-11-arm)pass on this PR / on main after mergejust ci: started, not finished before merge (merged early at the owner's request to unblock main)No screenshots: test-only change.