chore(types): add FE types for GET /notifications/admin/recent#2445
chore(types): add FE types for GET /notifications/admin/recent#2445innolope-dev wants to merge 1 commit into
Conversation
Sync the OpenAPI snapshot + regenerated TS types with the new admin diagnostics endpoint added in peanut-api-ts (surface failed notification sends). Additive only — no existing paths change.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
📝 WalkthroughWalkthroughAdded an OpenAPI definition for ChangesAdmin notification API
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Code-analysis diffPainscore total: 6207.05 → 6207.19 (+0.14) 🆕 New findings (355)
…and 335 more. ✅ Resolved (353)
…and 333 more. |
🧪 UI test report — ✅ all greenSuites
📊 Coverage (unit)
⏱ 10 slowest test cases
|
Review — ship ✅Purely additive generated diff (242+/0−): adds exactly the Merge order: logically mirrors BE peanut-api-ts#1197 — harmless to merge before it (FE never calls this route), but the snapshot is only truthful once #1197 lands. Land after #1197. |
kushagrasarathe
left a comment
There was a problem hiding this comment.
Approved — clean ship per full review. See review comment for merge-order sequencing.
Security note (non-blocking)These generated types are inert — no runtime code, no secret committed. Keeping the approval. One consumption caveat tied to BE #1197: the |
What
Regenerates the committed OpenAPI snapshot (
src/types/api.openapi.json) and TypeScript types (src/types/api.generated.ts) to include the new backend endpointGET /notifications/admin/recent, added in peanut-api-ts#1197.Notes
.prettierignored (snapshot is pulled verbatim from the BE spec), so the block is spliced in the BE's tab format rather than reformatted.pnpm gen:apioutput is idempotent, socheck:apipasses.x-admin-token), so the FE won't call it — this keeps the generated types a faithful mirror of the backend contract, nothing more.Depends on peanut-api-ts#1197 landing (the endpoint must exist on the BE for the types to be meaningful).
Summary by CodeRabbit