fix: warn about name mismatch on bank deposit details#2439
Conversation
Name mismatch (Bridge BE01) is the top cause of returned SEPA/ACH deposits, but the beneficiary/account-holder name was shown as a plain row while amount and reference got prominent warnings. Add a warning so users send from an account in their own name and enter the recipient name exactly as shown.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughThe bank details warning card now adds a sender-account ownership checklist item for all countries except Mexico. ChangesBank details warning
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Code-analysis diffPainscore total: 6206.68 → 6207.13 (+0.45) 🆕 New findings (4)
✅ Resolved (4)
|
🧪 UI test report — ✅ all greenSuites
📊 Coverage (unit)
⏱ 10 slowest test cases
|
Fold the name-match guidance into the existing 'Double check before sending' checklist card instead of a separate warning card, so there is one source of pre-send do-nots (no drift, no signal dilution from a fourth alarm card). Omit it for MX/SPEI, where paying from a third-party account is a supported flow and the own-name rule does not apply.
|
@coderabbitai review |
✅ Action performedReview finished.
|
✅ Action performedReview finished.
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/components/AddMoney/components/AddMoneyBankDetails.tsx`:
- Around line 417-425: The checklist in the items array must also instruct
non-MX users to enter the recipient/account-holder name exactly as shown. Extend
the existing currentCountryDetails?.id !== 'MX' conditional branch alongside the
sender warning, while keeping the MX omission behavior unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 5f08f51d-35a5-4498-a6be-f46b12c48e3e
📒 Files selected for processing (1)
src/components/AddMoney/components/AddMoneyBankDetails.tsx
BE01 validates the creditor (recipient) name too, not just the sender account. Add the recipient-name-exact line alongside the sender rule in the same non-MX branch.
Summary
Name mismatch is the top cause of returned SEPA/ACH deposits — Bridge confirmed (ticket #174270) that Banking Circle validates the sender name on every inbound transfer and auto-returns on mismatch (
BE01). The "Transfer details" screen already warns about amount and reference in a consolidated pre-send checklist, but said nothing about the name. This adds the missing name-match line to that same checklist.Context: TASK-20574 (non-EUR SEPA deposits). Investigation confirmed non-EUR SEPA deposits do work (the user's bank converts to EUR before it reaches Bridge); the real failure mode was always name mismatch, not currency — so this is the one user-facing gap worth closing.
Change
One conditional item added to the existing
Double check in your bank before sending:InfoCardinAddMoneyBankDetails.tsx. +6 lines, no logic change.Design notes
product/support-answers/bank-deposit-name-mismatch.md), so the item is gated out there.Risks / breaking changes
None. Pure additive UI copy on an existing screen. No API, no cross-repo impact.
QA
Sender: use a bank account in your own name…line.Summary by CodeRabbit