Skip to content

fix: warn about name mismatch on bank deposit details#2439

Merged
kushagrasarathe merged 3 commits into
devfrom
fix/sepa-name-match-warning
Jul 17, 2026
Merged

fix: warn about name mismatch on bank deposit details#2439
kushagrasarathe merged 3 commits into
devfrom
fix/sepa-name-match-warning

Conversation

@kushagrasarathe

@kushagrasarathe kushagrasarathe commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Summary

Name mismatch is the top cause of returned SEPA/ACH deposits — Bridge confirmed (ticket #174270) that Banking Circle validates the sender name on every inbound transfer and auto-returns on mismatch (BE01). The "Transfer details" screen already warns about amount and reference in a consolidated pre-send checklist, but said nothing about the name. This adds the missing name-match line to that same checklist.

Context: TASK-20574 (non-EUR SEPA deposits). Investigation confirmed non-EUR SEPA deposits do work (the user's bank converts to EUR before it reaches Bridge); the real failure mode was always name mismatch, not currency — so this is the one user-facing gap worth closing.

Change

One conditional item added to the existing Double check in your bank before sending: InfoCard in AddMoneyBankDetails.tsx. +6 lines, no logic change.

Design notes

  • Consolidated, not a new card. Folded into the existing pre-send checklist so there's a single source of pre-send do-nots — avoids a fourth alarm card diluting the signal and two places drifting out of sync. (Surfaced by /code-review.)
  • Omitted for MX/SPEI. The own-name rule is confirmed for ACH/SEPA/wire; Mexico SPEI supports paying from a third-party/client account (per product/support-answers/bank-deposit-name-mismatch.md), so the item is gated out there.
  • Deliberately did not touch the amount-step "EUR accounts only — your local currency account may not work" card; reframing it (now known over-cautious) is a separate product-copy call.

Risks / breaking changes

None. Pure additive UI copy on an existing screen. No API, no cross-repo impact.

QA

  • Add Money → any non-MX country → bank → enter amount → Continue → Transfer details: the pre-send checklist shows a third Sender: use a bank account in your own name… line.
  • Add Money → Mexico → bank: checklist shows only Amount + Reference (no sender-name line).

Summary by CodeRabbit

  • Improvements
    • Added a reminder to send funds from a bank account in the user’s own name during applicable bank transfer flows.
    • The reminder is omitted for Mexico-specific flows.

Name mismatch (Bridge BE01) is the top cause of returned SEPA/ACH
deposits, but the beneficiary/account-holder name was shown as a plain
row while amount and reference got prominent warnings. Add a warning so
users send from an account in their own name and enter the recipient
name exactly as shown.
@vercel

vercel Bot commented Jul 17, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
peanut-wallet Ready Ready Preview, Comment Jul 17, 2026 9:45am

Request Review

@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: d9e3a04e-b9c2-4f95-95cf-2f5ec95cb4b9

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

The bank details warning card now adds a sender-account ownership checklist item for all countries except Mexico.

Changes

Bank details warning

Layer / File(s) Summary
Conditional sender instruction
src/components/AddMoney/components/AddMoneyBankDetails.tsx
Adds a “Sender: use a bank account in your own name” checklist item for non-MX flows and documents the MX-specific omission.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: hugo0

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main UI copy change adding a bank-account name warning on bank deposit details.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/sepa-name-match-warning

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Code-analysis diff

Painscore total: 6206.68 → 6207.13 (+0.45)
Findings: 0 net (+4 new, -4 resolved)

🆕 New findings (4)

  • critical complexity — src/components/AddMoney/components/AddMoneyBankDetails.tsx — CC 83, MI 58.02, SLOC 153
  • high method-complexity — src/components/AddMoney/components/AddMoneyBankDetails.tsx:50 — AddMoneyBankDetails CC 33 SLOC 67
  • medium react-long-component — src/components/AddMoney/components/AddMoneyBankDetails.tsx:50 — AddMoneyBankDetails is 397 lines — split it
  • medium high-mdd — src/components/AddMoney/components/AddMoneyBankDetails.tsx:50 — AddMoneyBankDetails: MDD 114.5 (uses across many lines from declarations)

✅ Resolved (4)

  • src/components/AddMoney/components/AddMoneyBankDetails.tsx — CC 82, MI 58.12, SLOC 153
  • src/components/AddMoney/components/AddMoneyBankDetails.tsx:50 — AddMoneyBankDetails CC 32 SLOC 67
  • src/components/AddMoney/components/AddMoneyBankDetails.tsx:50 — AddMoneyBankDetails is 388 lines — split it
  • src/components/AddMoney/components/AddMoneyBankDetails.tsx:50 — AddMoneyBankDetails: MDD 112.7 (uses across many lines from declarations)

@github-actions

github-actions Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

🧪 UI test report — ✅ all green

Suites

  • unit: 1992 ran, 0 failed, 0 skipped, 32.2s

📊 Coverage (unit)

metric %
statements 59.6%
branches 43.2%
functions 48.5%
lines 59.9%
⏱ 10 slowest test cases
time test
3.7s src/components/Card/share-asset/__tests__/shareAssetLayout.test.ts › never places two stickers in heavy overlap (broad seed sweep)
1.2s src/utils/__tests__/demo-api.test.ts › isDemoMode() is false when not running under Capacitor
0.5s src/components/Card/share-asset/__tests__/shareAssetLayout.test.ts › every sticker stays within canvas at any count
0.3s src/app/actions/__tests__/api-headers-extended.test.ts › should not include apiKey in validateInviteCode body
0.3s src/app/(mobile-ui)/withdraw/__tests__/withdraw-states.test.tsx › Bank withdrawal keeps the $1 minimum for sub-$1 amounts
0.3s src/app/actions/__tests__/api-headers.test.ts › should include Content-Type in validateInviteCode
0.2s src/components/Card/share-asset/__tests__/shareAssetLayout.test.ts › keeps stickers off the username pill (final pass respects the keep-out)
0.2s src/utils/__tests__/demo-balance.test.ts › auto-refills a stored balance that has no timestamp (legacy install)
0.2s src/utils/__tests__/url.utils.test.ts › uses the public BASE_URL in Capacitor, not the localhost WebView origin
0.1s src/utils/__tests__/demo-balance.test.ts › resetDemoBalance refills and restarts the TTL window
📍 Inline annotations are in the **Unit test report** check above. Coverage artifact: `coverage-unit`. Generated by `.github/workflows/tests.yml`.

Fold the name-match guidance into the existing 'Double check before
sending' checklist card instead of a separate warning card, so there is
one source of pre-send do-nots (no drift, no signal dilution from a
fourth alarm card). Omit it for MX/SPEI, where paying from a third-party
account is a supported flow and the own-name rule does not apply.
@kushagrasarathe
kushagrasarathe marked this pull request as ready for review July 17, 2026 09:36
@kushagrasarathe

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/components/AddMoney/components/AddMoneyBankDetails.tsx`:
- Around line 417-425: The checklist in the items array must also instruct
non-MX users to enter the recipient/account-holder name exactly as shown. Extend
the existing currentCountryDetails?.id !== 'MX' conditional branch alongside the
sender warning, while keeping the MX omission behavior unchanged.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 5f08f51d-35a5-4498-a6be-f46b12c48e3e

📥 Commits

Reviewing files that changed from the base of the PR and between 679905f and 3d16f03.

📒 Files selected for processing (1)
  • src/components/AddMoney/components/AddMoneyBankDetails.tsx

Comment thread src/components/AddMoney/components/AddMoneyBankDetails.tsx
BE01 validates the creditor (recipient) name too, not just the sender
account. Add the recipient-name-exact line alongside the sender rule in
the same non-MX branch.
@kushagrasarathe
kushagrasarathe merged commit e5ffd30 into dev Jul 17, 2026
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant