Skip to content

Bindings release decouple - #2051

Merged
spacebear21 merged 2 commits into
payjoin:masterfrom
spacebear21:bindings-release-decouple
Nov 11, 2026
Merged

spacebear21 merged 2 commits into
payjoin:masterfrom
spacebear21:bindings-release-decouple

Conversation

@spacebear21

Copy link
Copy Markdown
Collaborator

This ensures a github release is created even if a downstream language's publishing job fails. It also skips Pypi publishing until the payjoin package ownership issue is resolved and trusted publishing can be configured.

Co-authored by Claude Code.

Pull Request Checklist

Please confirm the following before requesting review:

The github-release job needed all four registry publish jobs, so a
single registry failure skipped it. Every bindings release so far
(0.25.0, 0.25.1 and 0.26.0) shipped without a GitHub release because
the PyPI publish fails: PyPI has no trusted publisher for this workflow
and cannot have one until the project owns the `payjoin` package there.
npm, NuGet and pub.dev succeeded each time.

The GitHub release is a provenance and verification record, not a
distribution channel. Every published package bundles its own native
libraries or wasm, nothing downloads from the release, and all of its
assets come from the build jobs' artifacts rather than from the publish
jobs. Waiting on the registries only withholds that record when one of
them fails.

Make github-release need the same build gate as the publish jobs, plus
verify-tag for its version and prerelease outputs. The release is now
cut once every language build and smoke test passes, alongside the
publishes and regardless of their outcome, and re-running a failed
publish job leaves it alone. A failed or skipped build still skips the
release. Update the workflow header and RELEASING.md to match.
The publish-python job fails at the PyPI upload with
`invalid-publisher`: the project does not yet own the `payjoin` package
on PyPI, so no trusted publisher can be configured for this workflow.

Disable only the upload step with `if: false` until ownership is
resolved. The job still downloads the wheels, checks both are present
and attests their build provenance, and it stays behind the `release`
environment gate with the other publish jobs. The wheels still reach
the GitHub release. Update the workflow header and RELEASING.md where
they claimed Python is published to PyPI.

Re-enabling the PyPI publish is a revert of this commit.
@coveralls

Copy link
Copy Markdown
Collaborator

Coverage Report for CI Build 43085535738

Coverage remained the same at 87.825%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 18620
Covered Lines: 16353
Line Coverage: 87.82%
Coverage Strength: 313.92 hits per line

💛 - Coveralls

@benalleng benalleng left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK d5a29df

@spacebear21
spacebear21 merged commit 373645b into payjoin:master Nov 11, 2026
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants