Repository navigation
Bindings release decouple - #2051
Merged
spacebear21 merged 2 commits intoNov 11, 2026
Merged
Conversation
The github-release job needed all four registry publish jobs, so a single registry failure skipped it. Every bindings release so far (0.25.0, 0.25.1 and 0.26.0) shipped without a GitHub release because the PyPI publish fails: PyPI has no trusted publisher for this workflow and cannot have one until the project owns the `payjoin` package there. npm, NuGet and pub.dev succeeded each time. The GitHub release is a provenance and verification record, not a distribution channel. Every published package bundles its own native libraries or wasm, nothing downloads from the release, and all of its assets come from the build jobs' artifacts rather than from the publish jobs. Waiting on the registries only withholds that record when one of them fails. Make github-release need the same build gate as the publish jobs, plus verify-tag for its version and prerelease outputs. The release is now cut once every language build and smoke test passes, alongside the publishes and regardless of their outcome, and re-running a failed publish job leaves it alone. A failed or skipped build still skips the release. Update the workflow header and RELEASING.md to match.
The publish-python job fails at the PyPI upload with `invalid-publisher`: the project does not yet own the `payjoin` package on PyPI, so no trusted publisher can be configured for this workflow. Disable only the upload step with `if: false` until ownership is resolved. The job still downloads the wheels, checks both are present and attests their build provenance, and it stays behind the `release` environment gate with the other publish jobs. The wheels still reach the GitHub release. Update the workflow header and RELEASING.md where they claimed Python is published to PyPI. Re-enabling the PyPI publish is a revert of this commit.
Collaborator
Coverage Report for CI Build 43085535738Coverage remained the same at 87.825%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
benalleng
approved these changes
Nov 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ensures a github release is created even if a downstream language's publishing job fails. It also skips Pypi publishing until the
payjoinpackage ownership issue is resolved and trusted publishing can be configured.Co-authored by Claude Code.
Pull Request Checklist
Please confirm the following before requesting review: