Repository navigation
Monitor revamp followups - #2043
Merged
spacebear21 merged 3 commits intoNov 9, 2026
Merged
Conversation
`cancel --no-broadcast` printed "Broadcast the original transaction manually", while a failed broadcast now points users at --no-broadcast to close a session whose fallback is already on chain. Following that hint led to an instruction to broadcast a transaction that may already be confirmed or have spent inputs. Say the session closed without broadcasting, and to broadcast the printed fallback only if it isn't on chain and its inputs are unspent. The sender and receiver now print the same message.
The outcome a receiver records on close says whether the receiver completed its side of the Payjoin protocol and sent the Payjoin proposal, not which transaction resolved the session. A session that posted its proposal records PayjoinProposalSent even if the fallback resolved it, and the ResolvedBy classification is not persisted. Callers could otherwise expect a closed session to remember whether the Payjoin or the fallback settled it. State this in the close docs of ReceiveSession, Receiver<S> and the FFI close_session.
Collaborator
Coverage Report for CI Build 42720325922Coverage decreased (-0.02%) to 87.825%Details
Uncovered Changes
Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
payjoin-ffi removed Monitor.check_for_transaction outright, and the classify-tx fragment only names the replacement. Apps moving to classify_tx and close_session also need to know what changed in behavior. The recorded outcome no longer carries the txid or which transaction settled. Classification ignores confirmations. A Resolution does not survive a restart. Malformed bytes raise TransactionParseError. The bindings have no separate migration guide, and payjoin-ffi/CHANGELOG.md is their release notes, so list these in a changelog fragment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow ups from #2034:
cancel --no-broadcastno longer just tells users to broadcast the fallback manually; instead it says the session closed and to broadcast only if the fallback isn't on chain and its inputs are unspent.closedocs inpayjoinandpayjoin-ffinow explain that the recorded outcome says whether the receiver completed its side of the Payjoin protocol and sent the proposal, not which transaction resolved the session, and that the session doesn't persist theResolvedByclassification.Monitor.check_for_transactiontoclassify_txandclose_session.Assigned reviewer is @spacebear21 .
Pull Request Checklist
Please confirm the following before requesting review: