Skip to content

Replace httpx with httpx2 - #2021

Merged
benalleng merged 1 commit into
payjoin:masterfrom
benalleng:httpx-replacement
Oct 30, 2026
Merged

benalleng merged 1 commit into
payjoin:masterfrom
benalleng:httpx-replacement

Conversation

@benalleng

@benalleng benalleng commented Oct 29, 2026 •

Copy link
Copy Markdown
Collaborator

This replaces httpx with the more upkept httpx2. There is some drama around this but if you lock PRs and don't cut a release in ~2 years don't be shocked when people move on.

httpx2 drops support for python@3.10 https://github.com/pydantic/httpx2/blob/2fc91585813781bf0a1ebbf76d41136a0fe4a1f7/docs/migration.md?plain=1#L129

supersedes #2019

This wasn't auto updated as it is a transitive dep.

Also I wanted to bring up #2020 as related to this as we really only need alerts and not that much automation churn for this kind of thing

Pull Request Checklist

Please confirm the following before requesting review:

@coveralls

coveralls commented Oct 29, 2026 •

Copy link
Copy Markdown
Collaborator

Coverage Report for CI Build 41060798227

Coverage remained the same at 87.547%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 17947
Covered Lines: 15712
Line Coverage: 87.55%
Coverage Strength: 320.79 hits per line

💛 - Coveralls

@chavic

chavic commented Oct 30, 2026 •

Copy link
Copy Markdown
Collaborator

ACK 7f97f9c; @benalleng, we may need to add an entry under Unreleased in payjoin-ffi/CHANGELOG.md. Previously, the Python package required Python 3.10+ and httpx>=0.28.1,<1.0; this PR raises the minimum to Python 3.11 and replaces httpx with httpx2.

For example:

Python: require Python 3.11+ and replace httpx with httpx2. Callers catching HTTP errors from fetch_ohttp_keys should use httpx2.HTTPError instead of httpx.HTTPError.

This replaces httpx with the more upkept httpx2. There is some drama
around this but if you lock PRs and don't cut a release in ~2 years
don't be shocked when people move on.
@benalleng
benalleng requested review from chavic and removed request for chavic October 30, 2026 13:09
@benalleng
benalleng merged commit 2abd11a into payjoin:master Oct 30, 2026
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants