You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
From some post merge discussion I don't want to get lost. #1295 (comment) I think it would be helpful to come to a consensus on how we want to organize and document our gitignore. Though not mission critical I think a well organized gitignore can sometimes be helpful to make sense of all the generated files strewn about in a large repo.
I have been look into this, andit occurs to me that I agree with @nothingmuch, because as the project keeps becoming larger the more .ignore filewill. Better documentation will be required for each workspace. @benalleng I wil like to know what is the consensus. I think I can handle this.
I’d like to pick this up. @Hamza1610, are you still on it? Happy to coordinate if so. I looked at DanGould#18. It’s gone stale (it still references payjoin-directory), so I’d redo it on current master with one .gitignore per directory and a comment on every rule.
One thing I noticed: payjoin-cli and payjoin-mailroom write payjoin.sqlite and ./data/ to whatever directory you run them from. So per-crate rules don’t catch those when the binary runs from the repo root, which is why *.dat in payjoin-mailroom/.gitignore didn’t help in #1295.
My plan:
Build outputs and generated files go in their own directory’s .gitignore
Runtime files go in the root, using specific names (payjoin.sqlite, xor.dat, .ikm) instead of a bare data
Add .direnv/ and result, and drop the duplicate rules
Two questions: should .direnv/ go here or stay in #1353, and are the payjoin-ffi/ files in scope given the open bindings PRs? @DanGould@spacebear21 does this sound right?
I think we really haven't had much movement on the .gitignore since we had a flurry since making this issue. For the most part I think this issue may not totally be necessary but feel free to add some comments clarifying the ignores themselves that may be more obscure
Activity
nothingmuch commentedon Jan 26, 2026
i vote for separate files in subdirectories, seems more organized and easier to maintain organization as they grow
fwiw a good acceptance criteria should be that you don't have to do anything to start working with jujutsu on any part of the project
spacebear21 commentedon Jan 27, 2026
I agree with separate .gitignore files per directory. Adding explanatory comments for each line of ignore would be useful.
Hamza1610 commentedon Jul 7, 2026
I have been look into this, andit occurs to me that I agree with @nothingmuch, because as the project keeps becoming larger the more
.ignorefilewill. Better documentation will be required for each workspace.@benalleng I wil like to know what is the consensus. I think I can handle this.
mwihoti commentedon Nov 11, 2026
I’d like to pick this up. @Hamza1610, are you still on it? Happy to coordinate if so. I looked at DanGould#18. It’s gone stale (it still references payjoin-directory), so I’d redo it on current master with one .gitignore per directory and a comment on every rule.
One thing I noticed: payjoin-cli and payjoin-mailroom write payjoin.sqlite and ./data/ to whatever directory you run them from. So per-crate rules don’t catch those when the binary runs from the repo root, which is why *.dat in payjoin-mailroom/.gitignore didn’t help in #1295.
My plan:
Build outputs and generated files go in their own directory’s .gitignore
Runtime files go in the root, using specific names (payjoin.sqlite, xor.dat, .ikm) instead of a bare data
Add .direnv/ and result, and drop the duplicate rules
Two questions: should .direnv/ go here or stay in #1353, and are the payjoin-ffi/ files in scope given the open bindings PRs?
@DanGould @spacebear21 does this sound right?
benalleng commentedon Nov 11, 2026
I think we really haven't had much movement on the .gitignore since we had a flurry since making this issue. For the most part I think this issue may not totally be necessary but feel free to add some comments clarifying the ignores themselves that may be more obscure
Hamza1610 commentedon Nov 12, 2026
@benalleng I think you may be right. But nevertheless @mwihoti is already making a move on it, please you can carry on with it!