Repository navigation
refactor(tui): adopt upstream textarea viewport APIs - #16
Merged
Merged
Conversation
This was referenced Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the textarea fork synced with upstream through
14239e5, replacing the fork-specific viewport calls with upstream’s tuplescroll_offset()andscreen_to_data(). Preserve padding-aware clicks, Unicode layout, native cursor placement, and scrolling after deletion. Pin the tested fork commit6e7fa51; no unrelated dependencies change.Paired fork PR: paviro/notema-textarea#1
Validation:
CI Audit is blocked by existing
rustls 0.23.43(RUSTSEC-2026-0285) and yankedchacha20 0.10.1. Their lockfile entries are identical to baseline7179c6b; this PR does not modify them. Audit job.Open upstream PRs #36 and #37 are excluded. Rollback must revert this caller migration and dependency pin together; journal data needs no migration.