Skip to content

refactor(tui): adopt upstream textarea viewport APIs - #16

Merged
paviro merged 2 commits into
mainfrom
chore/sync-textarea-upstream
Oct 9, 2026
Merged

paviro merged 2 commits into
mainfrom
chore/sync-textarea-upstream

Conversation

@paviro

@paviro paviro commented Oct 9, 2026 •

Copy link
Copy Markdown
Owner

Use the textarea fork synced with upstream through 14239e5, replacing the fork-specific viewport calls with upstream’s tuple scroll_offset() and screen_to_data(). Preserve padding-aware clicks, Unicode layout, native cursor placement, and scrolling after deletion. Pin the tested fork commit 6e7fa51; no unrelated dependencies change.

Paired fork PR: paviro/notema-textarea#1

Validation:

  • Full workspace tests, both prescribed Clippy configurations, strict documentation checks, formatting, and build pass against the exact published Git pin.
  • New regression tests cover multilingual editor clicks across padding/scrolling/resizing and native cursor placement after deleting an overflowing field. Both passed against the previous dependency before migration.
  • 2,305 before/after fork render-and-interaction frames are identical.
  • A PTY smoke test preserved Unicode text after paste, undo/redo, resize, mouse wheel/selection, and save in a temporary journal.
  • Three interleaved benchmark runs per version show editor medians within -1.4% to +1.3%, with overlapping samples.
  • Fork CI passes on Linux, macOS, and Windows. Notema’s Linux lint/test/docs job and all platform compile checks pass, including macOS, Windows x64/ARM, Android, and cross targets. Rust CodeQL analysis is still running.

CI Audit is blocked by existing rustls 0.23.43 (RUSTSEC-2026-0285) and yanked chacha20 0.10.1. Their lockfile entries are identical to baseline 7179c6b; this PR does not modify them. Audit job.

Open upstream PRs #36 and #37 are excluded. Rollback must revert this caller migration and dependency pin together; journal data needs no migration.

@paviro
paviro merged commit d845dc7 into main Oct 9, 2026
19 of 20 checks passed
@paviro
paviro deleted the chore/sync-textarea-upstream branch October 9, 2026 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant