Repository navigation
Threat model (#84) - #85
Conversation
THREAT_MODEL.md: what cloudpin protects (cloud accounts, and never the credentials), whom it trusts (the person, the agent's good faith, the project's pin file, each CLI's own identity answer), the controls with the code behind each, and what is out of scope, notably a malicious or prompt-injected agent, which can edit the pin file or its own hook settings. SECURITY.md links to it; ROADMAP lists it under 1.1.0. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Question 1: I believe the Out of Scope list matches how I'd expect a seatbelt to behave and I think it's the right call, and the doc states that. I would add that cloudpin checks the account and not a repo, Vercel project, or a region that a command targets, and maybe suggest denying agents from making edits to |
- "Agent hooks never fail open" was too strong: if cloudpin can't start at all, Claude Code and Codex run the command. Now "fail closed once cloudpin is running", with that case stated and doctor named. - Variables set earlier in the line, and values only known when it runs, are a control now that #86 handles them. - Out of scope: which resource inside the account (repo, Vercel project, region); an agent's MCP tools for a cloud provider. - Advice: deny the agent edits to .cloudpin.yml and its hook settings. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Exactly what I needed. Q1: I added to the out of scope list that cloudpin checks the account (and the project, where one is pinned), but not which repo, Vercel project or region a command targets. I also added your suggestion: use the agent's own permission settings to deny it edits to Q2: You're right about "never fail open". It now says the hooks fail closed once cloudpin is running, and that if cloudpin can't start at all, Claude Code and Codex run the command anyway. Q3: Both of your examples turned out to be bugs in cloudpin itself. Feel free to take another look when you get a chance and you can approve it from Files changed > Review changes > Approve. Much appreciated. |
carlosrod1231
left a comment
There was a problem hiding this comment.
I'm going to approve: the changes cover everything I raised, and #87 fixes the two bypasses with tests for both. Before merging, the ROADMAP.md conflict needs resolving (main now lists this under 1.3.0), and since paureis/cloudpin#121 Wrangler’s .env files (which can hold CLOUDFLARE_API_TOKEN) should join the kubeconfig as credential files cloudpin reads, here and in SECURITY.md/README.
…ential files read Since #116 cloudpin reads the .env files Wrangler loads, which can hold CLOUDFLARE_API_TOKEN. SECURITY.md said credential files are not read except the kubeconfig, and README said the same. Both now name the .env files and what cloudpin takes from them. Raised in the review of #85. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
# Conflicts: # ROADMAP.md
… names (#84) From the review's approval: the .env files Wrangler loads can hold CLOUDFLARE_API_TOKEN, so they join the kubeconfig as credential files cloudpin reads, in THREAT_MODEL.md and SECURITY.md (the same SECURITY.md wording is on release/1.2.0, with the README line). Brought up to date with main: the user-only variables now live in src/user-env.ts (CLOUDPIN_BRANCH included, set or unset), help and version exempt only where the CLI stops on them (#146), redirections (#154), and a new control that says plainly the command-line parser is the weak point, links the 2026-10-26 audit issues and states the fail-closed aim. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Release 1.2.0: bump the version package.json, the package-lock.json root, plugin/.claude-plugin/plugin.json, both version fields in server.json, and the bug report form's example. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Release 1.2.0: CHANGELOG, README, ROADMAP and docs The CHANGELOG entry (with the GitHub Action under Added), README's latest release paragraph and its CI answer pointing at paureis/cloudpin-action, ROADMAP's Shipped list, and the "(1.2.0, out 2026-11-05)" notes dropped from README and docs/mcp.md. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * File-size guard: README.md may reach 6,500 tokens README is one page (install, configuration, every provider and agent) and had passed the guard's 5,000-token default, which blocked release edits. Owner decision 2026-10-23. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Release 1.2.0: the date moves to 2026-10-29 Owner decision 2026-10-23: ship a week early, because npm's 1.1.2 lacks the wrong-account fixes found this week (#125, #127, #130, #133) and the MCP Registry can only list a release that has mcpName. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Release 1.2.0: list #146 in the CHANGELOG, ROADMAP, README and DESIGN A help or version flag exempts only where the CLI stops on it, so README's "never blocked" line and DESIGN's block rule say so. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Release 1.2.0: list #154 and #156 in the CHANGELOG and ROADMAP Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Release 1.2.0: SECURITY and README name Wrangler's .env files as credential files read Since #116 cloudpin reads the .env files Wrangler loads, which can hold CLOUDFLARE_API_TOKEN. SECURITY.md said credential files are not read except the kubeconfig, and README said the same. Both now name the .env files and what cloudpin takes from them. Raised in the review of #85. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
SECURITY.md takes main's paragraph. THREAT_MODEL.md now covers cloudpin switch and the AWS config file it reads; CHANGELOG and ROADMAP lines for #84. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Closes #84
Adds
THREAT_MODEL.md: what cloudpin protects, whom it trusts, the controls (each naming the code that implements it), and what it deliberately doesn't try to stop. SECURITY.md links to it, and ROADMAP lists it under 1.3.0. Docs only; no code changes.Questions for a reviewer (about 15 minutes):
.cloudpin.ymlor its own hook settings.🤖 Generated with Claude Code
An outside review approved this on 2026-10-26. Merging it brought in
cloudpin switch, so the credentials control and a new switching control were updated after that review.