fix(components): complete stable control contracts - #294
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ConnectionSettings can now reject an invalid application ID before persistence or reconnect, and complex UI families derive stable control IDs from a caller-owned root. ImmersiveLanding owns its navigation and optional consent/PWA controls as one inventory subtree, repeated prompt instances avoid global IDs, and Slider uses the base-content token for visible thumb contrast.
The ThemeColorPicker CSP probe now tests a standard style attribute across frames. It treats missing computed-style support as unknown instead of permanently disabling theme colors, while still detecting a real browser CSP denial. Its native fixture now verifies that selecting a swatch produces an opaque applied accent, rather than accepting selection state alone.
The harness adds direct invalid-ID/non-commit checks, forward and backward landing navigation, Slider contrast, and applied-accent paint outcomes. Public API and usage docs cover the new validation and stable-ID contracts.
Validation on
0b2f646:bun run qa:build: pass{first:true,second:false}; no policy{first:true,second:true}Known repository baseline:
bun run lintreports 138 existing Biome errors, andbun run formatrewrites hundreds of unrelated files before failing to parse Tailwind's@themesyntax insrc/index.css. Formatter-only churn was restored; this PR contains only its six CSP/harness files plus the previously reviewed component work.The automated release workflow should derive 3.2.3 from these
fix:commits after review and merge. No manual version bump or publish is included.