Skip to content

Enforce unique endpoint method codes #20

Description

@dimadudin

This requires a refactor of build_object_lists. Implement a Visitor patter to:

for config in rust_configs {
        match config {
            Definition::Service(service) => {
                if services.iter().any(|prev| prev.id == service.id) {
                    return Err(eyre!(
                        "Found duplicate ID: {}, for Service: {}",
                        &service.id,
                        &service.name
                    ));
                }
                services.push(service)
            }
            Definition::EndpointSchema(service_name, service_id, endpoint_schema) => {
                service_schema_map
                    .entry((service_name, service_id))
                    .or_default()
                    .push(endpoint_schema)
            }
            Definition::EndpointSchemaList(service_name, service_id, endpoint_schemas) => {
                service_schema_map
                    .entry((service_name, service_id))
                    .or_default()
                    .extend(endpoint_schemas)
            }
            Definition::Enum(enum_type) => enums.push(enum_type),
            Definition::EnumList(enum_types) => enums.extend(enum_types),
            Definition::RoleList(role_types) => {
                enums.extend(role_types);
            }
        }
    }

This would also allow to sort endpoints/services in place

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions