ci(docs): decouple Pages from Bulletin - #368
Open
Imod7 wants to merge 5 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
docs-deploy.ymlpublishes to the Bulletin Chain then GitHub Pages in one job, with nothing shielding the Pages steps from a Bulletin failure. Three release deploys failed at Bulletin and published nothing, so the public site has served the 0.21.0 build since 2026-08-07 against a main at 0.27.0. This makes the two targets independent and fixes both causes.Changes
.github/workflows/docs-deploy.ymlcontinue-on-errorand a final step re-raises its outcome. Pages publishes either way, the run still goes red.skippedinstead ofsuccess, and the deploy checkout is pinned to the gated SHA.bulletin-deploy0.15.2 to 0.17.1. 0.15.2 predates the 2026-09-01 DotNS ABI change and calls aPopRules.startingPrice()that no longer exists onpaseo-next-v2, which is what the 09-01 and 09-03 runs failed on..github/scripts/check-docs-deploy.sh(new): the guard fromdocs-verify.yml, now runnable locally, plus assertions that the two properties above cannot be undone silently.Testing
The deploy runs only on a release or a dispatch, so the guard is what is testable.
Nothing under
product-sdk/changes, so the SDK and e2e suites are path-filtered out of this PR.Nothing here runs on push. The site updates on the next release, or now with
gh workflow run "docs: Deploy (Bulletin + Pages)" --repo paritytech/product-sdk --ref main. Pages publishes even if Bulletin still fails.